Support multi-app suborquestration #33
Conversation
| } | ||
|
|
||
| func WithAppID(targetAppID string) callActivityOption { | ||
| func WithActivityAppID(targetAppID string) callActivityOption { |
There was a problem hiding this comment.
This is necessary because the suborchestration and activity options live in the same task package.
There was a problem hiding this comment.
This should be fine since we have not released an SDK version with the original func name. If that wasn't the case we should need to create an alias for backwards compat.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
multiapp-suborquestration-wip
branch
from
086bd65 to
979834e
Compare
| if es := event.GetExecutionStarted(); es != nil && event.GetRouter() != nil { | ||
| parentAppID = event.GetRouter().GetSource() | ||
| break | ||
| } |
There was a problem hiding this comment.
Is it ever the case that there are multiple GetExecutionStarted? Should we not have a source/router type field on the ParentInstance to determine source app ID rather than searching in the event history?
There was a problem hiding this comment.
Makes sense, opened this PR adding this optional field.
There was a problem hiding this comment.
it's now approved/merged, will do the changes to use this new field
| } | ||
|
|
||
| func WithAppID(targetAppID string) callActivityOption { | ||
| func WithActivityAppID(targetAppID string) callActivityOption { |
There was a problem hiding this comment.
This should be fine since we have not released an SDK version with the original func name. If that wasn't the case we should need to create an alias for backwards compat.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
2 participants
This PR adds support for calling sub-workflows across different AppIDs.
This feature has been implemented in activities here.