-
Notifications
You must be signed in to change notification settings - Fork 6
Update upstream #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream #12
Conversation
…ons workflow (dapr#1) (microsoft#35) - Bump version in `pyproject.toml` to 0.2b1 and update Python requirement to >=3.9. - Add `protobuf` dependency in `requirements.txt`. - Update GitHub Actions workflow to support Python versions 3.9 to 3.13 and upgrade action versions. - Refactor type hints in various files to use `Optional` and `list` instead of `Union` and `List`. - Improve handling of custom status in orchestration context and related functions. - Fix purge implementation to pass required parameters. Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
…icrosoft#38) Signed-off-by: Albert Callarisa <albert@diagrid.io>
… submodule (microsoft#39) Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
* Creation of DTS example and passing of completionToken Signed-off-by: Ryan Lettieri <67934986+RyanLettieri@users.noreply.github.com> * Adressing review feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Reverting dapr readme Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding accessTokenManager class for refreshing credential token Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding comments to the example Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding in requirement for azure-identity Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Moving dts logic into its own module Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing whitesapce Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating dts client to refresh token Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Cleaning up construction of dts objects and improving examples Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Migrating shared access token logic to new grpc class Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding log statements to access_token_manager Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * breaking for loop when setting interceptors Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Removing changes to client.py and adding additional steps to readme.md Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Refactoring client and worker to pass around interceptors Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing import for DefaultClientInterceptorImpl Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adressing round 1 of feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing interceptor issue Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Moving some files around to remove dependencies Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adressing more feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * More review feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Passing token credential as an argument rather than 2 strings Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * More review feedback for token passing Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Addressing None comment and using correct metadata Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating unit tests Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing the type for the unit test Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing grpc calls Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fix linter errors and update documentation * Specifying version reqiuirement for pyproject.toml Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating README Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding comment for credential type Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> --------- Signed-off-by: Ryan Lettieri <67934986+RyanLettieri@users.noreply.github.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Co-authored-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Albert Callarisa <albert@diagrid.io>
) * Creating of pipeline to publish dts python package to pypi Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Upgrading version of durabletask-azuremanaged from 0.1b1 to 0.1 Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating versioning on packages Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Incrementing version to allign with pypi Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adressing majority of first round of feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating pipeline to have linting Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating versions in pyproject.toml Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating working dirs in yml Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding requirements.txt Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Moving durabletask tests into specific dir and more Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing more paths Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * ATtemptign to ignore durabletask-azuremanaged folder Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * installing dts dependencies Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Changing path for requirements.txt Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Moving init.py Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating readme and some tests Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Running all dts tests in publish pipeline Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Removing PYTHONPATH and installing regular deps Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding timeout to dts orchestration e2e test Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Removing suspend and continue as new tests from dts Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Removing raise event timeout tests Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Only runnign publish on tag push Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Changing dts action to run on tag creation Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating tag name Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adressing review feedback Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing run requirements in actions and adding exit-zero Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Update .github/workflows/publish-dts-sdk.yml --------- Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
…r release (microsoft#50) * Reconnect upon connection error * concurrency * Test updates * More updates * more concurrency stuff * final touches * fix import * update log level * fix exports * more fixup * test updateS * more test imports * fix github workflow pytest * cleanup tests * Python 3.9 specific test fix * fixup reconnection for new concurrency model * autopep8 * Remove existing duplicate import Signed-off-by: Albert Callarisa <albert@diagrid.io>
* Update GitHub workflows and automate release * Update linter config * more workflow changes * linter fixes * ignore new linter warning * even more workflow cleanup and improvement * declare asyncio as package dependency * Update requirements.txt Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
mikeee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial obs
CHANGELOG.md
Outdated
|
|
||
| - Added `set_custom_status` orchestrator API ([#31](https://github.com/microsoft/durabletask-python/pull/31)) - contributed by [@famarting](https://github.com/famarting) | ||
| - Added `purge_orchestration` client API ([#34](https://github.com/microsoft/durabletask-python/pull/34)) - contributed by [@famarting](https://github.com/famarting) | ||
| - Added new `durabletask-azuremanaged` package for use with the [Durable Task Scheduler](https://learn.microsoft.com/azure/azure-functions/durable/durable-task-scheduler/durable-task-scheduler) - by [@RyanLettieri](https://github.com/RyanLettieri) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Added new `durabletask-azuremanaged` package for use with the [Durable Task Scheduler](https://learn.microsoft.com/azure/azure-functions/durable/durable-task-scheduler/durable-task-scheduler) - by [@RyanLettieri](https://github.com/RyanLettieri) |
I think the Changelog needs to be clarified for this fork
Signed-off-by: Albert Callarisa <albert@diagrid.io>
The changelog entry removed mentions `azuremanaged`, and that's something we are not bringing from upstream. Signed-off-by: Albert Callarisa <albert@diagrid.io>
examples/README.md
Outdated
| 1. Install the latest version of the [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/), which contains and exposes an embedded version of the Durable Task engine. The setup process (which requires Docker) will configure the workflow engine to store state in a local Redis container. | ||
|
|
||
| 1. Clone and run the [Durable Task Sidecar](https://github.com/microsoft/durabletask-go) project locally (requires Go 1.18 or higher). Orchestration state will be stored in a local sqlite database. | ||
| 2. Clone and run the [Durable Task Sidecar](https://github.com/microsoft/durabletask-go) project locally (requires Go 1.18 or higher). Orchestration state will be stored in a local sqlite database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. Clone and run the [Durable Task Sidecar](https://github.com/microsoft/durabletask-go) project locally (requires Go 1.18 or higher). Orchestration state will be stored in a local sqlite database. | |
| 2. Clone and run the [Durable Task Sidecar](https://github.com/dapr/durabletask-go) project locally (requires Go 1.18 or higher). Orchestration state will be stored in a local sqlite database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or to make it easier, we could give the exact commands:
go install github.com/dapr/durabletask-go@main
durabletask-go --port 4001
dev-requirements.txt
Outdated
| @@ -1 +1 @@ | |||
| grpcio-tools==1.62.3 # 1.62.X is the latest version before protobuf 1.26.X is used which has breaking changes for Python | |||
| grpcio-tools | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already tried updating this dependency and there was a long discussion about it:
dapr/python-sdk#757 (comment)
I see this change is coming from upstream, but I'd like to understand what changed to make us change the decision we took in the comment above, cause all the raised points should still be valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream commit doesn't have much information about why they changed it.
Do you think we should keep the version as it was?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's keep it please
Signed-off-by: Albert Callarisa <albert@diagrid.io>
For context: dapr#12 (comment) Signed-off-by: Albert Callarisa <albert@diagrid.io>
|
@elena-kolevska Do you have any more comments here? |
Yeah, let's get the tests passing before giving it another look |
|
@elena-kolevska I think I've fixed them, can you trigger them please? |
This PR brings upstream changes into the dapr fork.
azuremanagedfilesdurabletask-python/tests/test_client.py
Lines 93 to 147 in 4602067