add non-retryable errors, and shutdown helpers #33

filintod · 2025-11-08T17:41:11Z

This is a split from asyncio PR #13 . Removing changes not related to asyncio changes

filintod · 2025-11-09T03:37:01Z

durabletask/client.py

        self._stub = stubs.TaskHubSidecarServiceStub(channel)
        self._logger = shared.get_logger("client", log_handler, log_formatter)

+    def __enter__(self):


add context manager option for clean closing

filintod · 2025-11-09T03:42:44Z

durabletask/client.py

+            # gRPC timeout mapping (pytest unit tests may pass None explicitly)
+            grpc_timeout = None if (timeout is None or timeout == 0) else timeout
+
+            # If timeout is None or 0, skip pre-checks/polling and call server-side wait directly


improves resource consumption on server side that might also lag behind client side

mypy.ini

filintod · 2025-11-09T03:46:45Z

durabletask/task.py

    pass


+class NonRetryableError(Exception):


this is a new helper, that is present in Temporal but not us, where we can defined errors that are non-retryable so activities don't attempt to retry when raised

filintod · 2025-11-09T03:48:58Z

durabletask/task.py

                    next_delay_f, self._retry_policy.max_retry_interval.total_seconds()
                )
-                return timedelta(seconds=next_delay_f)
+            return timedelta(seconds=next_delay_f)


this fixes a bug with retry, as the login in line 400 above f datetime.utcnow() < retry_expiration: means that we should retry, but as this was badly indented if for some reason max_retry_interval is not none this was not working.

this is also kind of mentioned in one of the gotchas in dapr/python-sdk#836, I found this bug beforehand, the other gotchas are gotchas or not-explained behavior

added some info in README to cover the gotchas, but we might need to add to python-sdk

filintod · 2025-11-09T04:44:42Z

examples/components/statestore.yaml

@@ -0,0 +1,16 @@
+apiVersion: dapr.io/v1alpha1


needed for e2e tests with dapr that should substitute durabletask-go tests with dapr setup

filintod · 2025-11-10T14:32:25Z

@acroca ptal

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

acroca · 2025-11-10T09:18:04Z

durabletask/internal/shared.py

    if log_handler is None:
        log_handler = logging.StreamHandler()
-        log_handler.setLevel(logging.INFO)
+        log_handler.setLevel(logging.DEBUG)


Why? Won't it get very noisy?

yes, a debugging leftover

acroca · 2025-11-10T15:07:41Z

tox.ini

 commands =
    !e2e: pytest -m "not e2e" --verbose
-    e2e: pytest -m e2e --verbose
+    e2e: pytest -m e2e --verbose 


Suggested change

e2e: pytest -m e2e --verbose

e2e: pytest -m e2e --verbose

acroca · 2025-11-11T10:01:00Z

durabletask/client.py

+                res: pb.GetInstanceResponse = self._stub.WaitForInstanceCompletion(
+                    req, timeout=grpc_timeout
+                )


I don't understand this. grpc_timeout is set to None in both 0 and None cases but if I understand correctly, when timeout is None we wait forever, but timeout 0 won't wait at all, right?

acroca · 2025-11-11T10:07:50Z

durabletask/client.py

+                    return current_state
+
+                # Poll for completion with exponential backoff to handle eventual consistency
+                import time


Move the import to the top of the file 🙏

acroca · 2025-11-11T10:37:02Z

durabletask/client.py

+                if current_state and current_state.runtime_status in [
+                    OrchestrationStatus.COMPLETED,
+                    OrchestrationStatus.FAILED,
+                    OrchestrationStatus.TERMINATED,
+                ]:


From https://github.com/dapr/durabletask-go/blob/7f28b2408db77ed48b1b03ecc71624fc456ccca3/api/orchestration.go#L196-L201, CANCELLED is also a condition for a workflow to be considered in a terminal state.
But what's the reason for this check? Why not just call the WaitForInstanceCompletion? You are still sending a call to the runtime to get the current state.

acroca · 2025-11-11T10:40:51Z

durabletask/task.py

        self._retry_timeout = retry_timeout
+        # Normalize non-retryable error type names to a set of strings
+        names: Optional[set[str]] = None
+        if non_retryable_error_types:


Suggested change

if non_retryable_error_types:

if non_retryable_error_types is not None:

acroca · 2025-11-11T10:42:13Z

durabletask/task.py

+                if isinstance(t, str):
+                    if t:


can't we check it all at once?

Suggested change

if isinstance(t, str):

if t:

if isinstance(t, str) and len(t)>0:

acroca · 2025-11-11T10:45:02Z

durabletask/worker.py

        self._channel_options = channel_options
+        self._stop_timeout = stop_timeout
+        # Track in-flight activity executions for graceful draining
+        import threading as _threading


Move this import to the top of the file 🙏

acroca · 2025-11-11T10:49:56Z

durabletask/worker.py

                current_reader_thread.start()
                loop = asyncio.get_running_loop()
                while not self._shutdown.is_set():
-                    try:


I don't see why this try was removed. If I understand correctly, the exceptions that were captured here will now be captured outside of the while, right? Why is this preferred now?

acroca · 2025-11-11T10:50:43Z

durabletask/worker.py

+        """
+        end: Optional[float] = None
+        if timeout is not None:
+            import time as _t


Move all the imports to the top please

filintod requested a review from a team as a code owner November 8, 2025 17:41

filintod force-pushed the filinto/asyncio-p1 branch from f6f6a40 to de68786 Compare November 9, 2025 02:25

filintod commented Nov 9, 2025

View reviewed changes

mypy.ini Outdated Show resolved Hide resolved

filintod commented Nov 9, 2025

View reviewed changes

filintod force-pushed the filinto/asyncio-p1 branch 2 times, most recently from df310f8 to d9ed06e Compare November 10, 2025 13:14

filintod mentioned this pull request Nov 10, 2025

[WORKFLOW SDK FEATURE REQUEST] Address many gotchas in workflow activities RetryPolicy dapr/python-sdk#836

Open

add non-retryable error, shutdown helpers, additional tests

7321905

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

filintod force-pushed the filinto/asyncio-p1 branch from d9ed06e to 7321905 Compare November 10, 2025 17:25

filintod changed the title ~~add new deterministic functions, non-retryable errors, and shutdown h…~~ add non-retryable errors, and shutdown helpers Nov 10, 2025

filintod mentioned this pull request Nov 10, 2025

add deterministic functions #34

Open

add info about non-retryable constraint to string matching

1930ba7

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

acroca reviewed Nov 11, 2025

View reviewed changes

	if non_retryable_error_types:
	if non_retryable_error_types is not None:

	if isinstance(t, str):
	if t:
	if isinstance(t, str) and len(t)>0:

add non-retryable errors, and shutdown helpers #33

Are you sure you want to change the base?

add non-retryable errors, and shutdown helpers #33

Conversation

filintod commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filintod Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filintod Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filintod commented Nov 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

filintod commented Nov 8, 2025 •

edited

Loading

filintod Nov 9, 2025 •

edited

Loading

filintod Nov 9, 2025 •

edited

Loading