Ensure checkstyle can be imported into IDE

dapr · Jul 19, 2024 · d7688f0 · d7688f0
1 parent 6e0f267
commit d7688f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -253,7 +253,7 @@
                 value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
     </module>
     <module name="JavadocMethod">
-      <property name="scope" value="public"/>
+      <property name="accessModifiers" value="public"/>
       <property name="allowedAnnotations" value="Override, Test"/>
     </module>
     <module name="MissingJavadocMethod">

diff --git a/pom.xml b/pom.xml
@@ -207,10 +207,9 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>3.3.1</version>
+        <version>3.4.0</version>
         <configuration>
           <configLocation>checkstyle.xml</configLocation>
-          <encoding>UTF-8</encoding>
           <consoleOutput>true</consoleOutput>
           <violationSeverity>warning</violationSeverity>
           <failOnViolation>true</failOnViolation>
@@ -233,7 +232,7 @@
           <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>8.37</version>
+            <version>10.17.0</version>
           </dependency>
         </dependencies>
       </plugin>

diff --git a/sdk-workflows/src/main/java/io/dapr/workflows/client/WorkflowInstanceStatus.java b/sdk-workflows/src/main/java/io/dapr/workflows/client/WorkflowInstanceStatus.java
@@ -149,8 +149,7 @@ public boolean isRunning() {
    * {@link WorkflowRuntimeStatus#FAILED}, or
    * {@link WorkflowRuntimeStatus#TERMINATED}.
    *
-   * @return {@code true} if the workflow was in a terminal state; otherwise
-   * {@code false}
+   * @return {@code true} if the workflow was in a terminal state; otherwise {@code false}
    */
   public boolean isCompleted() {
     return orchestrationMetadata.isCompleted();