Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto validation for Actors Examples #468

Closed
mukundansundar opened this issue Feb 1, 2021 · 4 comments · Fixed by #863
Closed

Add auto validation for Actors Examples #468

mukundansundar opened this issue Feb 1, 2021 · 4 comments · Fixed by #863
Assignees
Milestone

Comments

@mukundansundar
Copy link
Contributor

Describe the proposal

Add auto validation for Actors Java Examples. Follow the guides/examples in https://github.com/dapr/mechanical-markdown for more information on the validator used.
Similar to the PR #464.
Add the test for the actors example. It might need some changes to make the output deterministic enough for it to be validated.

@mukundansundar mukundansundar changed the title Add auto validation for Actors Java Examples Add auto validation for Actors Examples Feb 1, 2021
@mukundansundar mukundansundar added the help wanted Extra attention is needed label Feb 1, 2021
@artursouza artursouza added this to the v1.1 milestone Feb 15, 2021
@mukundansundar mukundansundar self-assigned this Feb 25, 2021
@mukundansundar
Copy link
Contributor Author

Need out of order processing support from mm.py. Since there are 3 actors in the example that are there which are called from independent threads, there is no order guarantee on which actor is called first. Similarly for the reminders and timers, since there is more than one actor, any actors can be pinged first or reminded of a state first.

Created an issue dapr/mechanical-markdown#18 to add ability to mm.py for outoforder processing.

The other option here is to limit the example to a single actor and then use the current available validations in mm.py.

@artursouza thoughts? Personally I do not like changing the example and limiting it to a single actor call.

@artursouza
Copy link
Member

@mukundansundar I agree. We need out of order processing before we can add this validation.

@artursouza artursouza removed this from the v1.1 milestone Apr 3, 2021
@mukundansundar mukundansundar removed their assignment Nov 19, 2021
@tanvigour
Copy link
Contributor

/assign

@mukundansundar
Copy link
Contributor Author

With the addition of match_order: none and output_match_mode directives, we have the capabilities to match/validate non-deterministic output order as well as substring matches for lines now.

@mukundansundar mukundansundar self-assigned this May 23, 2023
@mukundansundar mukundansundar added this to the v1.9 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants