Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup auto validation of java examples #464

Merged
merged 3 commits into from
Jan 31, 2021
Merged

Conversation

mukundansundar
Copy link
Contributor

@mukundansundar mukundansundar commented Jan 30, 2021

Description

Added auto validation based on manual trigger for now.

Current Actors example code is not deterministic enough for auto validation.
Also tracing is also not deterministic for validation.

Example successful validation build: https://github.com/mukundansundar/java-sdk/runs/1796635852?check_suite_focus=true

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar mukundansundar marked this pull request as ready for review January 30, 2021 08:50
wcs1only
wcs1only previously approved these changes Jan 30, 2021
Copy link
Contributor

@wcs1only wcs1only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #464 (6682e71) into master (ba49606) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #464      +/-   ##
============================================
- Coverage     80.25%   80.12%   -0.14%     
+ Complexity      982      981       -1     
============================================
  Files            89       89              
  Lines          3049     3049              
  Branches        328      328              
============================================
- Hits           2447     2443       -4     
- Misses          440      443       +3     
- Partials        162      163       +1     
Impacted Files Coverage Δ Complexity Δ
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <0.00%> (-25.00%) 1.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba49606...6682e71. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants