Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Update Dapr CLI + Add HTTP code to DaprException #1020

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

artursouza
Copy link
Member

Description

Cherry-picking from 1.11:

  • Update Dapr CLI
  • Add HTTP code to DaprException

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from a team as code owners February 21, 2024 20:01
@artursouza artursouza force-pushed the cherry_pick_1_11 branch 2 times, most recently from be58419 to 42091eb Compare February 21, 2024 22:16
mukundansundar
mukundansundar previously approved these changes Feb 22, 2024
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
cicoyle
cicoyle previously approved these changes Mar 5, 2024
@artursouza artursouza added this to the v1.12 milestone Jun 25, 2024
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (d759c53) to head (ff60862).
Report is 25 commits behind head on master.

Current head ff60862 differs from pull request most recent head 7454272

Please upload reports for the commit 7454272 to get more accurate results.

Files Patch % Lines
...rc/main/java/io/dapr/exceptions/DaprException.java 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1020      +/-   ##
============================================
+ Coverage     76.91%   77.72%   +0.80%     
+ Complexity     1592     1575      -17     
============================================
  Files           145      144       -1     
  Lines          4843     4808      -35     
  Branches        562      565       +3     
============================================
+ Hits           3725     3737      +12     
+ Misses          821      785      -36     
+ Partials        297      286      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit 363b6f9 into dapr:master Jun 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants