Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTEL to v1.39.0 in integration tests #1064

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

While we were trying to upgrade to Spring Boot 3.2.x and 3.3.x as part of #1050 we saw that TracingIT tests are failing. Upon further investigation it was clear that there are mismatches between OTEL that is brought in by Spring Boot 3.2.x and the OTEL version used in integration tests. This PR tries to upgrade OTEL to version 1.39.0 which is the latest. available version.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1063

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle this is another tiny PR to make sure that #1050 can be successfully completed. Please take a look and let me know your thoughts.

@artur-ciocanu
Copy link
Contributor Author

@salaboy and @ThomasVitale once this PR is merged I think we are pretty close to have the #1050 build 🟢.

@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle the build passed and everything looks good. Could you please review and merge. Thank you!

@artursouza artursouza changed the title Upgrade OTEL to v1.39.0 Upgrade OTEL to v1.39.0 in integration tests Jul 1, 2024
@artursouza artursouza added this to the v1.12 milestone Jul 1, 2024
@artursouza artursouza merged commit a0ee8d1 into dapr:master Jul 1, 2024
8 checks passed
@artur-ciocanu artur-ciocanu deleted the gh-1063 branch July 8, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade OTEL to version 1.39.0
2 participants