-
Notifications
You must be signed in to change notification settings - Fork 223
Add JavaTimeModule #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add JavaTimeModule #1065
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4118d16
Allow customize ObjectSerializer using a custom ObjectMapper
mcruzdev 369736c
Merge branch 'master' into issue-995
artur-ciocanu d5aa742
Apply pull request suggestions
mcruzdev 8bd1140
Merge branch 'master' into issue-995
salaboy bc0d57f
Merge branch 'master' into issue-995
artur-ciocanu dd77422
Merge branch 'master' into issue-995
artur-ciocanu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
sdk/src/main/java/io/dapr/serializer/CustomizableObjectSerializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package io.dapr.serializer; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import io.dapr.client.ObjectSerializer; | ||
|
|
||
| public class CustomizableObjectSerializer extends ObjectSerializer implements DaprObjectSerializer { | ||
|
|
||
| private final ObjectMapper objectMapper; | ||
|
|
||
| public CustomizableObjectSerializer(ObjectMapper objectMapper) { | ||
| this.objectMapper = objectMapper; | ||
| } | ||
|
|
||
| @Override | ||
| public ObjectMapper getObjectMapper() { | ||
| return objectMapper; | ||
| } | ||
|
|
||
| @Override | ||
| public String getContentType() { | ||
| return "application/json"; | ||
| } | ||
| } |
83 changes: 83 additions & 0 deletions
83
sdk/src/test/java/io/dapr/serializer/CustomObjectSerializerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright 2021 The Dapr Authors | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package io.dapr.serializer; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonInclude; | ||
| import com.fasterxml.jackson.databind.DeserializationFeature; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.SerializationFeature; | ||
| import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule; | ||
| import com.google.common.base.Objects; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.Serializable; | ||
| import java.time.ZoneId; | ||
| import java.time.ZonedDateTime; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
artur-ciocanu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public class CustomObjectSerializerTest { | ||
|
|
||
| private static final DaprObjectSerializer SERIALIZER = | ||
| new CustomizableObjectSerializer(new ObjectMapper() | ||
| .registerModule(new JavaTimeModule()) | ||
| .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false) | ||
| .setSerializationInclusion(JsonInclude.Include.NON_NULL) | ||
| .disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)); | ||
|
|
||
| public static class ObjectForTesting implements Serializable { | ||
| private ZonedDateTime time; | ||
|
|
||
| public ZonedDateTime getTime() { | ||
| return time; | ||
| } | ||
|
|
||
| public void setTime(ZonedDateTime time) { | ||
| this.time = time; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| ObjectForTesting that = (ObjectForTesting) o; | ||
| return Objects.equal(time, that.time); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hashCode(time); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void serializeObjectForTesting() { | ||
| ObjectForTesting obj = new ObjectForTesting(); | ||
| obj.setTime(ZonedDateTime.of(1900, 1, 1, 1, 1, 0, 0, ZoneId.of("UTC"))); | ||
| String expectedResult = | ||
| "{\"time\":\"1900-01-01T01:01:00Z\"}"; | ||
|
|
||
| String serializedValue; | ||
| try { | ||
| serializedValue = new String(SERIALIZER.serialize(obj)); | ||
| assertEquals(expectedResult, serializedValue, | ||
| "FOUND:[[" + serializedValue + "]] \n but was EXPECTING: [[" + expectedResult + "]]"); | ||
| } catch (IOException exception) { | ||
| fail(exception.getMessage()); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.