Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust latency and jitter for Toxi proxy to stabilize SDK resiliency IT #1070

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

There have been several instances during Spring Boot 3.x upgrade work #1050, where it has been noted that SDK resiliency IT test is failing. This PRs adjusts the latency and jitter used by Toxi Proxy to ensure that IT is passes reliably.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1069

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu artur-ciocanu requested review from a team as code owners July 8, 2024 12:29
Artur Ciocanu added 2 commits July 8, 2024 15:39
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle could you please review this PR. It tries to fix the last failing test in #1050.

If it looks good could you please merge and merge master to #1050 so we could ensure that Spring Boot 3.x upgrade is looking good.

Thank you!

@salaboy
Copy link
Contributor

salaboy commented Jul 9, 2024

/LGTM can we please approve and merge this @cicoyle @artursouza

@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle could you please take a look and merge this PR. Thank you!

@artursouza artursouza merged commit a4ec275 into dapr:master Jul 10, 2024
8 checks passed
@artur-ciocanu artur-ciocanu deleted the gh-1069 branch July 10, 2024 09:40
@cicoyle cicoyle added this to the v1.12 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK resiliency IT test might fail from time to time
4 participants