Initial Testcontainers integration for Dapr #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1040-testcontainers
branch
4 times, most recently
from
5a5b119 to
8b81027
Compare
salaboy
commented
Jul 22, 2024
salaboy
force-pushed
the
1040-testcontainers
branch
from
edc310d to
d27016b
Compare
|
@artursouza @cicoyle I couldn't check why it is complaining about License Compliance.. can you help me out to check that? |
salaboy
force-pushed
the
1040-testcontainers
branch
from
9a93e12 to
8e0f523
Compare
testcontainers-dapr/src/test/resources/components/statestore.yaml
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprComponentTest.java
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprComponentTest.java
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprComponentTest.java
Show resolved
Hide resolved
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
artur-ciocanu
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
@salaboy the PR looks really good, I have left a few comments, mostly stylistic. Please take a look.
Thank you!
|
@salaboy it is not a deal breaker, but it would be good to have the |
salaboy
force-pushed
the
1040-testcontainers
branch
from
0dcb766 to
83a460a
Compare
3 tasks
artursouza
requested changes
Jul 24, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/main/java/io/dapr/testcontainers/QuotedBoolean.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprContainerTest.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprContainerTest.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/test/resources/components/statestore.yaml
Outdated
Show resolved
Hide resolved
salaboy
force-pushed
the
1040-testcontainers
branch
from
d55cf8d to
4238719
Compare
cicoyle
reviewed
Jul 25, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
salaboy
force-pushed
the
1040-testcontainers
branch
from
792561d to
3984e4a
Compare
|
I removed Rest Assured, so one less dependency. But WireMock is mocking a webserver, so I think we cannot use Mockito for that. |
artursouza
reviewed
Jul 26, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/Component.java
Outdated
Show resolved
Hide resolved
artursouza
reviewed
Jul 26, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
artursouza
reviewed
Jul 26, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
artursouza
reviewed
Jul 26, 2024
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
artursouza
previously approved these changes
Aug 3, 2024
|
Refactored the script to update the version of artifacts. Also fixed to use "docker compose" instead of "docker-compose". Approved. Will merge once tests pass. |
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Usage: docker compose [OPTIONS] COMMAND
Define and run multi-container applications with Docker
Options:
--all-resources Include all resources, even those not used by services
--ansi string Control when to print ANSI control characters ("never"|"always"|"auto") (default "auto")
--compatibility Run compose in backward compatibility mode
--dry-run Execute command in dry run mode
--env-file stringArray Specify an alternate environment file
-f, --file stringArray Compose configuration files
--parallel int Control max parallelism, -1 for unlimited (default -1)
--profile stringArray Specify a profile to enable
--progress string Set type of progress output (auto, tty, plain, quiet) (default "auto")
--project-directory string Specify an alternate working directory
(default: the path of the, first specified, Compose file)
-p, --project-name string Project name
Commands:
attach Attach local standard input, output, and error streams to a service's running container
build Build or rebuild services
config Parse, resolve and render compose file in canonical format
cp Copy files/folders between a service container and the local filesystem
create Creates containers for a service
down Stop and remove containers, networks
events Receive real time events from containers
exec Execute a command in a running container
images List images used by the created containers
kill Force stop service containers
logs View output from containers
ls List running compose projects
pause Pause services
port Print the public port for a port binding
ps List containers
pull Pull service images
push Push service images
restart Restart service containers
rm Removes stopped service containers
run Run a one-off command on a service
scale Scale services
start Start services
stats Display a live stream of container(s) resource usage statistics
stop Stop services
top Display the running processes
unpause Unpause services
up Create and start containers
version Show the Docker Compose version information
wait Block until the first service container stops
watch Watch build context for service and rebuild/refresh containers when files are updated
Run 'docker compose COMMAND --help' for more information on a command. instead of docker-compose
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
1040-testcontainers
branch
from
b30aa8a to
e383fa3
Compare
|
@artursouza the |
@salaboy can you fix this? Using |
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the testcontainers-dapr module to the Java SDK. The main reason to have this code here is to improve the Spring Boot integration, while providing a common way to start the Dapr Runtime for Java applications by using Testcontainers
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1040
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: