Adding Java header to parent pom.xml #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artursouza and @cicoyle this is another tiny PR that requires your attention. Thank you! |
|
@artursouza and @cicoyle I was wondering is there a way to re-trigger the build? Sometimes we have IT tests failing because of container setup delays etc and I think it would be good to have a way to re-trigger the build without commits. |
|
I do rerun them on GH actions. But GH only allows that with certain permissions, it is not open to all. |
I see, makes sense. @artursouza if the PR looks good could you please merge? |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
artursouza
approved these changes
Jul 24, 2024
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 27, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 27, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a tiny issue with Checkstyle so we can run it from submodules as well. This was discovered by @salaboy.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1086
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: