Drop Java 8 API compatibility, enforce Java 11 API compatibility #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@artursouza and @cicoyle do let me know if you think this PR can be merged or if there are valid reason to force Java 8 API compatibility. |
Contributor
Author
|
@artursouza and @cicoyle could you please review and let me know if this PR looks good. Thank you! |
Contributor
Author
|
@artursouza as discussed over Discord, could you please approve this PR? Thank you. |
Contributor
Author
|
@artursouza and @cicoyle could you please review, approve and merge. Thank you! BTW the build 🟢 ! |
cicoyle
approved these changes
Aug 8, 2024
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
This looks ok to me given people who want java 8 still will use earlier versions of the sdk.
artursouza
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes Maven Animal Sniffer plugins and ensures that Dapr Java SDK enforces Java 11 API compatibility. This eventually will help us migrate to Java 17, when we are ready.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1092
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: