Support static Properties overrides on DaprClientBuilder

[salaboy]

Description

After discussing this with @cicoyle and @artursouza I've created this PR to provide a way to override variables that are set using System properties and environments.

Issue reference

Fixes #1096

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[salaboy]

@artursouza @cicoyle the issue in the pipeline seems to a flaky test more than an issue caused by the changes in this PR
Can we retrigger?

[artur-ciocanu]

@salaboy everything looks good!

[cicoyle]

This looks to be a little more than flaky:

MethodInvokeIT.testInvokeTimeout:95 Message: DEADLINE_EXCEEDED: context deadline exceeded does not start with: DEADLINE_EXCEEDED: deadline exceeded after ==> expected: <true> but was: <false>

I dont know that its related to this PR, but its consistent

[salaboy]

@cicoyle now it is a different one: https://github.com/dapr/java-sdk/actions/runs/10318759933/job/28670836841?pr=1097

BindingIT.inputOutputBinding:49->BaseIT.startDaprApp:49->BaseIT.startDaprApp:68->BaseIT.startDaprApp:130 » IllegalState Could not find success criteria for command: dapr run --app-id bindingit-grpc-inputbindingservice --app-protocol http --config ./configurations/configuration.yaml --resources-path ./components --app-port 36851 --dapr-http-port 40149 --dapr-grpc-port 34267 -- mvn exec:java -D exec.mainClass=io.dapr.it.binding.http.InputBindingService -D exec.classpathScope=test -D exec.args="36851"

[artur-ciocanu]

This looks to be a little more than flaky:

MethodInvokeIT.testInvokeTimeout:95 Message: DEADLINE_EXCEEDED: context deadline exceeded does not start with: DEADLINE_EXCEEDED: deadline exceeded after ==> expected: <true> but was: <false>

I dont know that its related to this PR, but its consistent

@cicoyle actually the test should be adjusted. I am not entirely sure how GRPC decides to fire a "StatusRuntimeException", but sometime it contains "DEADLINE context deadline ..." in other cases it contains "DEADLINE after timeout ...".

I think looking for "DEADLINE" should be enough.

Let me know your thoughts.

[salaboy]

@artur-ciocanu @cicoyle @artursouza For some reason, I was experimenting with similar "different" error messages popping up. For example, if I run some tests from my IDE, I will get different error messages than if I run them from the terminal or in CI. I don't know why but it makes me think that error codes are not super deterministic, if I don't remember wrong @cicoyle did you worked on that?

[salaboy]

@cicoyle @artursouza look at the issues now.. completely different and on setup ..
Can we merge this and solve any related consistent problems in the following PR that depends on this one?

[artur-ciocanu]

@salaboy the PR looks great, I have a left a tiny comment.

[artur-ciocanu]

@artursouza and @cicoyle could you please review. Thank you.

[artur-ciocanu]

@salaboy something is off ... GitHub says that there are Files changed 1,284. Could you please take a look.

[artur-ciocanu]

@salaboy could you please rebase from master.

[salaboy]

@artursouza is this going to be merged?

[artursouza]

One test run is not passing. Automerge takes care of updating the branch and merging after all tests pass.

[salaboy]

Arghh.. it was green before - Blog: http://salaboy.com <http://salaboy.wordpress.com> - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino -

…

On Thu, 22 Aug 2024 at 18:13, Artur Souza ***@***.***> wrote: One test run is not passing. Automerge takes care of updating the branch and merging after all tests pass. — Reply to this email directly, view it on GitHub <#1097 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACCMXVVADD4AFMMAIIPCU3ZSZWDJAVCNFSM6AAAAABMIFUHRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVHA4TSNJTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[salaboy]

@artursouza here we go again.. all tests are green now