Remove all global state from setProperty #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursouza
force-pushed
the
stable_tests
branch
4 times, most recently
from
1d0cd03 to
bb3c173
Compare
artur-ciocanu
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@artursouza the PR looks great! I have left a few tiny comments regarding switching to use Map.of() instead of relying on Collections.unmodifiableMap().
artursouza
force-pushed
the
stable_tests
branch
from
bb3c173 to
b89ef70
Compare
|
@artursouza you might want to re-trigger the build. It seems that there is race condition between Testcontainers and Spring Boot Test Context for a particular test. |
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
stable_tests
branch
from
b89ef70 to
60f4c29
Compare
|
@cicoyle we need your approval again since the PR has changed. Thank you! |
|
@artursouza it's not critical, but there a few more places in the PR where I mentioned that we could use |
artursouza
force-pushed
the
stable_tests
branch
2 times, most recently
from
20bf045 to
e4a373c
Compare
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
stable_tests
branch
from
e4a373c to
408b75f
Compare
artursouza
changed the title
artursouza
commented
Oct 2, 2024
| @@ -86,6 +87,7 @@ public void beforeEach() throws InterruptedException { | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled("Test is flaky due to global state in the spring test application.") | |||
There was a problem hiding this comment.
@salaboy This test is flaky, it has global state for setting properties somewhere. I disabled it until we find it. Can you help in a new PR after this?
There was a problem hiding this comment.
Created a tracking issue.
Done |
cicoyle
previously approved these changes
Oct 2, 2024
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
stable_tests
branch
from
be40d48 to
23ec1cc
Compare
cicoyle
approved these changes
Oct 2, 2024
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Remove all global state in from setProperty Signed-off-by: Artur Souza <asouza.pro@gmail.com> * use Map.of Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Remove dependency that is not needed. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all global state in from setProperty
Added properties to ActorClient
Fixed constructor visibility for ActorClient
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: