Skip to content

Update DaprActorsIT wait strategy #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mcruzdev
Copy link
Contributor

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1305

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Sorry, something went wrong.

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev marked this pull request as ready for review April 11, 2025 18:59
@mcruzdev mcruzdev requested review from a team as code owners April 11, 2025 18:59
@salaboy
Copy link
Collaborator

salaboy commented May 6, 2025

@mcruzdev can you please check the codecov and resolve the conflicts?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate as to why this change was made? Why change the message here from actor runtime started to found subscription message pattern for actors?

@mcruzdev
Copy link
Contributor Author

mcruzdev commented May 6, 2025

Can you elaborate as to why this change was made? Why change the message here from actor runtime started to found subscription message pattern for actors?

I tested locally here some times and I think we can close this pull request.

@mcruzdev mcruzdev closed this May 6, 2025
@mcruzdev mcruzdev deleted the issue-1305 branch May 6, 2025 15:24
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (d759c53) to head (e7678e4).
Report is 136 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1306      +/-   ##
============================================
+ Coverage     76.91%   77.42%   +0.50%     
- Complexity     1592     1764     +172     
============================================
  Files           145      204      +59     
  Lines          4843     5368     +525     
  Branches        562      587      +25     
============================================
+ Hits           3725     4156     +431     
- Misses          821      899      +78     
- Partials        297      313      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve ContainerLaunch Timed out exception
3 participants