-
Notifications
You must be signed in to change notification settings - Fork 223
[1.15] Cherrypick wf retry handler #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.15] Cherrypick wf retry handler #1418
Conversation
* Add retry handler support Signed-off-by: Mason <theforbiddenai@gmail.com> * Wrap DurableTask objects Signed-off-by: Mason <theforbiddenai@gmail.com> * Rename method Signed-off-by: Mason <theforbiddenai@gmail.com> * Add isNonRetriable field to WorkflowTaskFailureDetails Signed-off-by: Mason <theforbiddenai@gmail.com> * Add unit test Signed-off-by: Mason <theforbiddenai@gmail.com> * Removed duplicate WorkflowFailureDetails class Signed-off-by: Mason <theforbiddenai@gmail.com> * Removed unneeded when statements in retry policy unit test Signed-off-by: Mason <theforbiddenai@gmail.com> * Add unit test to test both RetryPolicy and RetryHandler Signed-off-by: Mason <theforbiddenai@gmail.com> * Create toRetryPolicy method Signed-off-by: Mason <theforbiddenai@gmail.com> --------- Signed-off-by: Mason <theforbiddenai@gmail.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
siri-varma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #1418 +/- ##
===============================================
Coverage ? 77.60%
Complexity ? 1788
===============================================
Files ? 207
Lines ? 5519
Branches ? 600
===============================================
Hits ? 4283
Misses ? 916
Partials ? 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Add retry handler support * Wrap DurableTask objects * Rename method * Add isNonRetriable field to WorkflowTaskFailureDetails * Add unit test * Removed duplicate WorkflowFailureDetails class * Removed unneeded when statements in retry policy unit test * Add unit test to test both RetryPolicy and RetryHandler * Create toRetryPolicy method --------- Signed-off-by: Mason <theforbiddenai@gmail.com> Co-authored-by: Mason <TheForbiddenAI@gmail.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com>
* Add retry handler support * Wrap DurableTask objects * Rename method * Add isNonRetriable field to WorkflowTaskFailureDetails * Add unit test * Removed duplicate WorkflowFailureDetails class * Removed unneeded when statements in retry policy unit test * Add unit test to test both RetryPolicy and RetryHandler * Create toRetryPolicy method --------- Signed-off-by: Mason <theforbiddenai@gmail.com> Co-authored-by: Mason <TheForbiddenAI@gmail.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com>
Cherrypick this PR