Skip to content

Pull out createTimer logic #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

Pull out createTimer logic #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12843f1
pull out logical changes from @salaboy's PR to release it
cicoyle Jun 11, 2025
966ab2d
merge in master
cicoyle Jun 11, 2025
cbfbbbf
add missing import
cicoyle Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sdk-workflows/src/main/java/io/dapr/workflows/WorkflowContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,7 @@ default Task<Task<?>> anyOf(Task<?>... tasks) {
* @param zonedDateTime timestamp with specific zone when the timer should expire
* @return a new {@code Task} that completes after the specified delay
*/
default Task<Void> createTimer(ZonedDateTime zonedDateTime) {
throw new UnsupportedOperationException("This method is not implemented.");
}

Task<Void> createTimer(ZonedDateTime zonedDateTime);

/**
* Gets the deserialized input of the current task orchestration.
Expand Down
6 changes: 6 additions & 0 deletions sdk-workflows/src/main/java/io/dapr/workflows/runtime/DefaultWorkflowContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

import java.time.Duration;
import java.time.Instant;
import java.time.ZonedDateTime;
import java.util.List;
import java.util.UUID;

Expand Down Expand Up @@ -189,6 +190,11 @@ public Task<Void> createTimer(Duration duration) {
return this.innerContext.createTimer(duration);
}

@Override
public Task<Void> createTimer(ZonedDateTime zonedDateTime) {
return this.innerContext.createTimer(zonedDateTime);
}

/**
* {@inheritDoc}
*/
Expand Down
19 changes: 11 additions & 8 deletions sdk-workflows/src/test/java/io/dapr/workflows/DefaultWorkflowContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,10 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.*;

public class DefaultWorkflowContextTest {
private DefaultWorkflowContext context;
Expand Down Expand Up @@ -124,6 +120,11 @@ public Task<Void> createTimer(Duration duration) {
return null;
}

@Override
public Task<Void> createTimer(ZonedDateTime zonedDateTime) {
return null;
}

@Override
public <V> V getInput(Class<V> targetType) {
return null;
Expand Down Expand Up @@ -269,8 +270,10 @@ public void createTimerTest() {
}

@Test
public void createTimerWithZonedDateTimeThrowsTest() {
assertThrows(UnsupportedOperationException.class, () -> context.createTimer(ZonedDateTime.now()));
public void createTimerWithZonedDateTimeTest() {
ZonedDateTime now = ZonedDateTime.now();
context.createTimer(now);
verify(mockInnerContext, times(1)).createTimer(now);
}

@Test
Expand Down
Loading