Skip to content

Conversation

javier-aliaga
Copy link
Contributor

Description

Use latest RC version

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga marked this pull request as ready for review September 1, 2025 09:05
@javier-aliaga javier-aliaga requested review from a team as code owners September 1, 2025 09:05
@salaboy
Copy link
Collaborator

salaboy commented Sep 1, 2025

@javier-aliaga This is a well known flaky ->

BindingIT.inputOutputBinding:89->BaseIT.startDaprApp:50->BaseIT.startDaprApp:69->BaseIT.startDaprApp:109 » IllegalState Could not find success criteria for command: dapr run --app-id bindingit-grpc-inputbindingservice --app-protocol http --config ./configurations/configuration.yaml --resources-path ./components --app-port 43235 --dapr-http-port 37939 --dapr-grpc-port 42397 -- mvn exec:java -D exec.mainClass=io.dapr.it.binding.http.InputBindingService -D exec.classpathScope=test -D exec.args="43235"

@salaboy
Copy link
Collaborator

salaboy commented Sep 1, 2025

But then this is new:

DaprConversationIT.testConversationSDKShouldScrubPIIOnlyForTheInputWhereScrubPIIIsSet:129 expected: <input this abcd@gmail.com> but was: <input this abcd@gmail.com

@javier-aliaga
Copy link
Contributor Author

@salaboy , I am checking the second one, probably a regression, but I will need to confirm

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@salaboy
Copy link
Collaborator

salaboy commented Sep 1, 2025

LGTM

@salaboy salaboy merged commit 8fa4e9d into dapr:master Sep 1, 2025
10 checks passed
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.72%. Comparing base (d759c53) to head (151cd1f).
⚠️ Report is 212 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1539      +/-   ##
============================================
+ Coverage     76.91%   78.72%   +1.81%     
- Complexity     1592     1923     +331     
============================================
  Files           145      237      +92     
  Lines          4843     5932    +1089     
  Branches        562      610      +48     
============================================
+ Hits           3725     4670     +945     
- Misses          821      939     +118     
- Partials        297      323      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Sep 2, 2025
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request Sep 2, 2025
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request Sep 2, 2025
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request Sep 2, 2025
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request Sep 2, 2025
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
salaboy added a commit that referenced this pull request Sep 3, 2025
* process deps too for dapr-spring (#1503)

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Use camelCase on properties (#1470)

* Use camelCase on properties

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

* Add test for cameCalse properties

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

* Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md

Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>

---------

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* fix script (#1506)

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* add support for custom status (#1505)

Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* try 1.5.7 (#1487)

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* rm protoc cmd from pom.xml (#1498)

* rm protoc cmd bc it uses a local protoc which might be the wrong version and results in a bad error

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update protoc

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* feat: Support registering activities with custom name (#1431)

* feat: Support register of activities with custom name

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Apply suggestions

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Bump codecov/codecov-action from 5.4.3 to 5.5.0 (#1513)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.3 to 5.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.4.3...v5.5.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* commit: Fix validate job (#1524)

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: New task execution task id test (#1352) (#1526)

* chore: New task execution task id test

test how taskExecutionTaskId can be used for idempotency

* chore: Clean up not used files

* docs: Task execution keys

* test: Modify unit tests

* Remove new lines

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Bump actions/checkout from 4 to 5 (#1504)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Improve CI runs (#1527)

* chore: Wait for dapr script

When running mechanical markdown examples wait for dapr to be running

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix build ci

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix build ci

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>
Co-authored-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Fix CVEs (#1529)

* chore: Read test certs from resources folder

This will avoid importing bouncy castle library just for tests

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* ci: Split unit test and integration tests

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* fix: Use correct snapshot url (#1530)

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Bump actions/setup-java from 4 to 5 (#1512)

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Bump dapr version (#1539)

* chore: Bump dapr version

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Adding logger to WorkflowActivityContext (#1534)

* Adding logger to WorkflowActivityContext

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Fixing a styling issue

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Add unit tests for workflow activity context

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Add more unit tests to make Codecov happy

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Add more unit tests

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Improve code coverage

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

* Improve test names

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>

---------

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Co-authored-by: Artur Ciocanu <ciocanu@adobe.com>
Co-authored-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Use notimestamp in Javadoc Plugin to disable timestamps in Javadocs (#1538)

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Feat Cross App CallActivity (#1468)

* cross app ex

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update protoc cmd

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* feedback

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* builder pattern

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* fix protoc

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* debug log levels for test containers

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update readme and add debugging info

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* add IT test for cross app call activity

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* cleanup test

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* sysout -> ctx.logger

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* reset pom

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm debug lines from readme

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* fix header + rm customports

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* use consts

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm waitfor call

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm pubsub

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm timeout

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* reset empty lines added

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* reset appname for daprcontainer

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* reset empty line diff

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm constructor info from readme

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* debug -> info

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm super.start

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* reset dapr container diff

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* add test for codecov

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* up timeout time to unblock PR

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* deps: Update durabletask-client to 1.5.10

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* ci: Revert build timeout

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* review: Use ctx.getLogger

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Fix review comments

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: more review comments fixes

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* test: Use testcontainers in CrossApp IT test

Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Load classpath for IT with all dependencies

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Co-authored-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* Release 1.16.0-rc-1

Signed-off-by: Dapr Bot <daprweb@microsoft.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* process deps too for dapr-spring (#1502)

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>

* chore: Alpha components to stable

Signed-off-by: Javier Aliaga <javier@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Dapr Bot <daprweb@microsoft.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Artur Ciocanu <ciocanu@adobe.com>
Co-authored-by: Dapr Bot <daprweb@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants