Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add input bindings section #776

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

hhunter-ms
Copy link
Contributor

Signed-off-by: Hannah Hunter hannahhunter@microsoft.com

Description

Add input bindings section to Java doc.

Issue reference

PR will close: dapr/docs#2770

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners September 9, 2022 18:18
@hhunter-ms
Copy link
Contributor Author

@artursouza Filling documentation gap. I don't know Java well, so definitely will need review/feedback on the example.

@hhunter-ms hhunter-ms mentioned this pull request Sep 9, 2022
11 tasks
@RequestMapping("/")
public class myClass {
private static final Logger log = LoggerFactory.getLogger(myClass);
@PostMapping(path = "/checkout")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, include the method too since annotations don't work by themselves.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #776 (bbb4bb2) into master (bbb6a1d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #776   +/-   ##
=========================================
  Coverage     76.25%   76.25%           
  Complexity     1119     1119           
=========================================
  Files           101      101           
  Lines          3516     3516           
  Branches        410      410           
=========================================
  Hits           2681     2681           
  Misses          637      637           
  Partials        198      198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hhunter-ms
Copy link
Contributor Author

@artursouza updated - let me know if this example fits with the other Java SDK examples, too

@artursouza artursouza merged commit 44f80c9 into dapr:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK documentation gaps
2 participants