Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for configuration api #813

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

sarsharma
Copy link
Contributor

Signed-off-by: Sarthak Sharma sartsharma@microsoft.com

Description

Please explain the changes you've made

Fix the info for configuration api docs

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
@sarsharma sarsharma requested review from a team as code owners November 24, 2022 19:30
pravinpushkar
pravinpushkar previously approved these changes Nov 25, 2022
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #813 (1292b27) into master (bc9de9f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #813   +/-   ##
=========================================
  Coverage     77.62%   77.62%           
  Complexity     1161     1161           
=========================================
  Files           105      105           
  Lines          3647     3647           
  Branches        419      419           
=========================================
  Hits           2831     2831           
  Misses          603      603           
  Partials        213      213           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mukundansundar mukundansundar added this to the v1.8 milestone Nov 25, 2022
@mukundansundar mukundansundar merged commit 7593b0e into dapr:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants