Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HTTP client with warning. #824

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

artursouza
Copy link
Member

Signed-off-by: Artur Souza asouza.pro@gmail.com

Description

Deprecate HTTP Client.

Takes over #790

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #794

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza requested review from a team as code owners January 24, 2023 19:16
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #824 (6f7ecd0) into master (81591b9) will decrease coverage by 0.05%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master     #824      +/-   ##
============================================
- Coverage     77.97%   77.92%   -0.05%     
- Complexity     1258     1260       +2     
============================================
  Files           116      116              
  Lines          3887     3892       +5     
  Branches        457      458       +1     
============================================
+ Hits           3031     3033       +2     
- Misses          625      627       +2     
- Partials        231      232       +1     
Impacted Files Coverage Δ
...ain/java/io/dapr/actors/client/DaprHttpClient.java 100.00% <ø> (ø)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 86.89% <ø> (ø)
.../src/main/java/io/dapr/client/DaprClientProxy.java 75.86% <ø> (ø)
.../src/main/java/io/dapr/client/DaprHttpBuilder.java 94.44% <ø> (ø)
sdk/src/main/java/io/dapr/config/Properties.java 81.81% <ø> (ø)
...c/main/java/io/dapr/actors/client/ActorClient.java 62.96% <33.33%> (-1.04%) ⬇️
...rc/main/java/io/dapr/client/DaprClientBuilder.java 64.28% <33.33%> (-2.39%) ⬇️
.../src/main/java/io/dapr/client/DaprApiProtocol.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@artursouza
Copy link
Member Author

I validated the output in one of our validation runs for examples:

== APP == 2023-01-24 19:41:04,943 {HH:mm:ss.SSS} [main] WARN io.dapr.client.DaprClientBuilder - HTTP client protocol is deprecated and will be removed in Dapr's Java SDK version 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Deprecate HTTP client in SDK
2 participants