Add additional CloudEvent fields (pubsubname, topic, time, etc) #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursouza
requested changes
May 24, 2023
|
I will also look into how I can add a DCO sign-off to my commit(s). |
… traceparent, & tracestate) Added the com.fasterxml.jackson:jackson-datatype-jsr310 dependency to handle serdes of OffsetDateTime for the CloudEvent time field via ObjectMapper settings .configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false) & .findAndRegisterModules() Updated com.fasterxml.jackson dependencies to the latest 2.15.1 Added OffsetDateTime as timeValue to test the DefaultObjectSerializer Added more tests for new & old CloudEvent fields in CloudEventTest & DefaultObjectSerializerTest Signed-off-by: Luke Sieben <siebenluke@gmail.com>
Removed the 2 new constructors Signed-off-by: Luke Sieben <siebenluke@gmail.com>
…ames as JSON/OBJECT_MAPPER are case-sensitive Signed-off-by: Luke Sieben <siebenluke@gmail.com>
artursouza
requested changes
Jun 26, 2023
…ency in favor of custom field level serdes for time Signed-off-by: Luke Sieben <siebenluke@gmail.com>
artursouza
previously approved these changes
Aug 15, 2023
… end of the offending lines to a new line Signed-off-by: Luke Sieben <siebenluke@gmail.com>
|
@siebenluke - mind resolving the conflicts? Then I think we can merge this |
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
|
Hi @cicoyle / @artursouza, I have resolved the conflicts, so if someone (Artur) could take another look that would be great. Thanks. |
artursouza
previously approved these changes
Dec 22, 2023
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
|
Hi @cicoyle / @artursouza, Happy New Years, I believe I've added all the necessary CloudEvent test cases in 78e9575 to appease Codecov. Let me know if there are any other additional changes I need to make before this can be merged. |
artursouza
previously approved these changes
Jan 5, 2024
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
Signed-off-by: Luke Sieben <siebenluke@gmail.com>
artursouza
approved these changes
Jan 11, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
============================================
+ Coverage 76.29% 76.85% +0.56%
- Complexity 1463 1497 +34
============================================
Files 138 138
Lines 4497 4524 +27
Branches 524 530 +6
============================================
+ Hits 3431 3477 +46
+ Misses 784 773 -11
+ Partials 282 274 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
Add additional CloudEvent fields (pubsubname, topic, time, traceid, traceparent, & tracestate) per discussion in Discord chat
Checklist