Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Per Actor Type Configuration #892

Closed
wants to merge 8 commits into from

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Aug 4, 2023

Description

Implements support for per Actor Type configurations of the Actor Runtime

Issue reference

Fixes #729

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

MregXN added 5 commits July 27, 2023 23:21
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN requested review from a team as code owners August 4, 2023 10:15
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN force-pushed the actor-configuration branch from 254be0a to 3f6aafa Compare August 5, 2023 03:53
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN force-pushed the actor-configuration branch from 3f6aafa to b3fbc92 Compare August 5, 2023 05:10
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #892 (7645c1a) into master (cf8040d) will increase coverage by 0.32%.
The diff coverage is 88.15%.

@@             Coverage Diff              @@
##             master     #892      +/-   ##
============================================
+ Coverage     76.94%   77.27%   +0.32%     
- Complexity     1326     1356      +30     
============================================
  Files           126      128       +2     
  Lines          4091     4167      +76     
  Branches        484      494      +10     
============================================
+ Hits           3148     3220      +72     
+ Misses          696      694       -2     
- Partials        247      253       +6     
Files Changed Coverage Δ
.../io/dapr/actors/runtime/ActorObjectSerializer.java 85.71% <79.41%> (+1.00%) ⬆️
...n/java/io/dapr/actors/runtime/ActorTypeConfig.java 92.00% <92.00%> (ø)
.../io/dapr/actors/runtime/ActorReentrancyConfig.java 100.00% <100.00%> (ø)
...ava/io/dapr/actors/runtime/ActorRuntimeConfig.java 100.00% <100.00%> (+8.69%) ⬆️

@cicoyle cicoyle mentioned this pull request Sep 14, 2023
3 tasks
@cicoyle
Copy link
Contributor

cicoyle commented Sep 14, 2023

I opened #914 to get this PR to a mergeable state, since I don't have permission to push to the original branch

@artursouza artursouza added this to the v1.10 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Per Actor Type Configuration
3 participants