-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add determinstic UUID generation #947
Conversation
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Hi @cicoyle , would you mind helping me to rerun the CI, I added one more test to improve the coverage. |
Hey @kaibocai, the Java-sdk maintainers are the only ones able to run CI and my understanding is that there is flakiness. However, I can ping Artur for re-running CI. I believe he won't merge this until there is a PR updating the example |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
892f301
to
fbafb0a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
============================================
+ Coverage 76.58% 76.59% +0.01%
- Complexity 1465 1467 +2
============================================
Files 137 137
Lines 4468 4470 +2
Branches 526 526
============================================
+ Hits 3422 3424 +2
Misses 761 761
Partials 285 285 ☔ View full report in Codecov by Sentry. |
* add determinstic UUID generation Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test to improve coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <kaibocai@microsoft.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: kaibocai <kaibocai@microsoft.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com>
* Show registered workflow Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (#945) * add NewWorkflowOption Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * fix style Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add more unit tests for improving coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Update CLI link in example readme's (#951) * Updated pre-requisite link to Dapr CLI Signed-off-by: Michaël Hompus <michael@hompus.nl> * Update JDK list to match all other examples Signed-off-by: Michaël Hompus <michael@hompus.nl> --------- Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * remove static Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add determinstic UUID generation (#947) * add determinstic UUID generation Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test to improve coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <kaibocai@microsoft.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: kaibocai <kaibocai@microsoft.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test ActorExceptionIT (#954) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky it ActorReminderRecovery (#958) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test MethodInvokeIT (#959) * fix flaky it MethodInvokeIT Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add more waiting time Signed-off-by: MregXN <mregxn@gmail.com> * wait before invoke Signed-off-by: MregXN <mregxn@gmail.com> * wait for health before invoke Signed-off-by: MregXN <mregxn@gmail.com> --------- Signed-off-by: MregXN <mregxn@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Fix errors Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * make thead safe * Fix code and test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: kaibocai <kaibocai@microsoft.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Co-authored-by: Michaël Hompus <michael@hompus.nl> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
* Show registered workflow Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (dapr#945) * add NewWorkflowOption Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * fix style Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add more unit tests for improving coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Update CLI link in example readme's (dapr#951) * Updated pre-requisite link to Dapr CLI Signed-off-by: Michaël Hompus <michael@hompus.nl> * Update JDK list to match all other examples Signed-off-by: Michaël Hompus <michael@hompus.nl> --------- Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * remove static Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add determinstic UUID generation (dapr#947) * add determinstic UUID generation Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test to improve coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <kaibocai@microsoft.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: kaibocai <kaibocai@microsoft.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test ActorExceptionIT (dapr#954) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky it ActorReminderRecovery (dapr#958) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test MethodInvokeIT (dapr#959) * fix flaky it MethodInvokeIT Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add more waiting time Signed-off-by: MregXN <mregxn@gmail.com> * wait before invoke Signed-off-by: MregXN <mregxn@gmail.com> * wait for health before invoke Signed-off-by: MregXN <mregxn@gmail.com> --------- Signed-off-by: MregXN <mregxn@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Fix errors Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * make thead safe * Fix code and test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: kaibocai <kaibocai@microsoft.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Co-authored-by: Michaël Hompus <michael@hompus.nl> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
* Show registered workflow * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (#945) * add NewWorkflowOption * fix style * add unit test * add more unit tests for improving coverage --------- * Update CLI link in example readme's (#951) * Updated pre-requisite link to Dapr CLI * Update JDK list to match all other examples --------- * remove static * Add determinstic UUID generation (#947) * add determinstic UUID generation * add unit test to improve coverage * update grpc version to 1.59.0 to be compatible updated durabletask-java --------- * fix flaky integration test ActorExceptionIT (#954) * fix flaky it ActorReminderRecovery (#958) * fix flaky integration test MethodInvokeIT (#959) * fix flaky it MethodInvokeIT * add debug print * add debug print * add more waiting time * wait before invoke * wait for health before invoke --------- * Fix errors * make thead safe * Fix code and test. --------- Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: kaibocai <kaibocai@microsoft.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Co-authored-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Co-authored-by: Michaël Hompus <michael@hompus.nl> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Description
This PR add logic to generated a determinstic UUID to for workflow.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #931
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: