-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving and Adding Logs for Workflow #978
Conversation
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
@RyanLettieri Can you look into the coverage checks that are failing in this PR? |
The coverage checks are due to the switch case statement for the log levels. We log what the log level was set to in the switch case statements, I.e. "Severe", "Warning", etc. I didn't believe it made much sense to create test cases for each individual log level but if needed I certainly can. |
sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
…i/java-sdk into workflow-log-tracing
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
============================================
+ Coverage 76.23% 76.29% +0.06%
- Complexity 1462 1463 +1
============================================
Files 138 138
Lines 4489 4497 +8
Branches 524 524
============================================
+ Hits 3422 3431 +9
Misses 784 784
+ Partials 283 282 -1 ☔ View full report in Codecov by Sentry. |
Description
Added in logging statements for dapr workflow and optional parameter for setting the log level.
Note that the failures are due to every individual case of a large switch-case statement not being tested
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #946
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: