add wait for sidecar docs & update java-sdk docs to match .net more w… #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ client separation Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
cicoyle
requested review from
hhunter-ms and
a team
and removed request for
a team
artursouza
approved these changes
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
=========================================
Coverage 76.29% 76.29%
Complexity 1463 1463
=========================================
Files 138 138
Lines 4497 4497
Branches 524 524
=========================================
Hits 3431 3431
Misses 784 784
Partials 282 282 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add wait for sidecar and shutdown docs to sdk docs page. also updated file name to match docs requirement here, stating files/folders should start w/
java-. I also addedAvailable packagesto the landing page for the java sdk docs (in line w/ dotnet landing page). I also changed the java-workflow.md to be java-workflow-howto.md since that is how dotnet had it.Issue reference
docs for: #918
Checklist