Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples and docs for subscribing to configuration stores #524

Conversation

shubham1172
Copy link
Member

Description

Doc changes and add examples to subscribe to config stores

Issue reference

Please reference the issue this PR will close: #465

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 requested review from a team as code owners September 21, 2023 07:21
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bec157c) 35.23% compared to head (0a8715e) 35.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   35.23%   35.23%           
=======================================
  Files          90       90           
  Lines       10143    10143           
  Branches      415      415           
=======================================
  Hits         3574     3574           
  Misses       6503     6503           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@XavierGeerinck XavierGeerinck self-requested a review September 21, 2023 10:04
@XavierGeerinck
Copy link
Contributor

approved!

@XavierGeerinck XavierGeerinck added this pull request to the merge queue Sep 21, 2023
Merged via the queue into dapr:main with commit 28367ef Sep 21, 2023
@hhunter-ms hhunter-ms mentioned this pull request Sep 25, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add Config Subscribe example to client doc
2 participants