-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Bump to 3.4.0-rc.1 - use dapr 1.14.0-rc.x #611
Conversation
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Seems same issue that is happening here in e2e test (https://github.com/dapr/js-sdk/actions/runs/10111456256/job/27967538117) has been also reported for java-sdk: dapr/dapr#7938 |
@DeepanshuA should have been fixed with rc.6 / dapr/dapr#7940 |
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See question on version pls.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@dapr/dapr", | |||
"version": "3.3.1", | |||
"version": "3.4.0-rc.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeepanshuA are we sticking with 3.3.1 to go with Dapr 1.14.0, or bumping to 3.4? I see that the key bug fix you made for health probe went into 3.3.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js-sdk ver 3.3.1 was released already. We would release 3.4.0 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once dapr 1.14 is released finally, will do so. As of now, dapr 1.14 rc versions are out, so creating js-sdk versions in sync with that.
test:e2e is failing intermittenntly. I have tested on local as well, it is passing. |
@holopin-bot @DeepanshuA Thanks Deepanshu! |
Congratulations @DeepanshuA, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvakqzn16210cjybmv9xu12 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
* fix: typo (#607) Update AbstractActor.ts Signed-off-by: Bond <4683867+bondz@users.noreply.github.com> * fix: Remove broken image links (#610) Update README.md Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com> * Fix README.md for distributedlock example (#613) Update README.md Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> * [chore] Bump to 3.4.0-rc.1 - use dapr 1.14.0-rc.x (#611) * use dapr 1.14.0-rc.6 Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Version correction Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Update .github/workflows/test-e2e.yml Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * update Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * update Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> --------- Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Mike Nguyen <hey@mike.ee> * Updating package json with final release version 3.4.0 Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Regenerated protos by updating and running ./scripts/fetch-proto.sh Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating test workflow with correct Dapr Runtime and CLI versions Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> --------- Signed-off-by: Bond <4683867+bondz@users.noreply.github.com> Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Bond <4683867+bondz@users.noreply.github.com> Co-authored-by: Joe Bowbeer <joe.bowbeer@gmail.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Co-authored-by: Mike Nguyen <hey@mike.ee>
Description
Using dapr/dapr 1.14.0-rc.x version.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: