Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A whole new client #93

Merged
merged 12 commits into from
Jul 16, 2021
Merged

A whole new client #93

merged 12 commits into from
Jul 16, 2021

Conversation

withinboredom
Copy link
Contributor

@withinboredom withinboredom commented Jun 10, 2021

Description

This adds a whole new Dapr Client in /Dapr/Client/DaprClient which is completely incompatible with the existing client. Currently, it only supports the HTTP API, but gRPC is coming 🔜.

This PR serves as a base PR to merge to as existing SDK technology is ported to the new client.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Addresses: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@withinboredom withinboredom added the enhancement New feature or request label Jun 10, 2021
@withinboredom withinboredom self-assigned this Jun 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #93 (ffa4a64) into main (d53e986) will decrease coverage by 5.24%.
The diff coverage is 0.00%.

❗ Current head ffa4a64 differs from pull request most recent head aef25f2. Consider uploading reports for the commit aef25f2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #93      +/-   ##
============================================
- Coverage     73.61%   68.36%   -5.25%     
- Complexity      396      448      +52     
============================================
  Files            49       59      +10     
  Lines          1459     1571     +112     
============================================
  Hits           1074     1074              
- Misses          385      497     +112     
Impacted Files Coverage Δ
src/lib/Client/AppId.php 0.00% <0.00%> (ø)
src/lib/Client/DaprClient.php 0.00% <0.00%> (ø)
src/lib/Client/DaprClientBuilder.php 0.00% <0.00%> (ø)
src/lib/Client/DaprHttpClient.php 0.00% <0.00%> (ø)
src/lib/Client/HttpBindingTrait.php 0.00% <0.00%> (ø)
src/lib/Client/HttpInvokeTrait.php 0.00% <0.00%> (ø)
src/lib/Client/HttpPubSubTrait.php 0.00% <0.00%> (ø)
src/lib/Client/HttpSecretsTrait.php 0.00% <0.00%> (ø)
src/lib/Client/HttpStateTrait.php 0.00% <0.00%> (ø)
src/lib/Client/PromiseHandlingTrait.php 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53e986...aef25f2. Read the comment docs.

@withinboredom withinboredom added this to the v1.2.0 milestone Jun 10, 2021
@withinboredom withinboredom merged commit 57efb04 into main Jul 16, 2021
@withinboredom withinboredom deleted the add/daprclient-2 branch July 16, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants