Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubsub to use new client #98

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Update pubsub to use new client #98

merged 5 commits into from
Jul 16, 2021

Conversation

withinboredom
Copy link
Contributor

Description

This updates pubsub to use the new client.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #98 (ab96eb6) into main (57efb04) will decrease coverage by 1.65%.
The diff coverage is 33.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #98      +/-   ##
============================================
- Coverage     68.36%   66.70%   -1.66%     
- Complexity      448      455       +7     
============================================
  Files            59       59              
  Lines          1571     1682     +111     
============================================
+ Hits           1074     1122      +48     
- Misses          497      560      +63     
Impacted Files Coverage Δ
src/index.php 0.00% <0.00%> (ø)
src/lib/Client/PromiseHandlingTrait.php 57.14% <0.00%> (+57.14%) ⬆️
src/lib/PubSub/Publish.php 100.00% <ø> (ø)
src/lib/PubSub/Topic.php 85.00% <81.25%> (-15.00%) ⬇️
src/config.php 100.00% <100.00%> (ø)
src/lib/Client/DaprClient.php 53.84% <100.00%> (+53.84%) ⬆️
src/lib/Client/DaprClientBuilder.php 46.66% <100.00%> (+46.66%) ⬆️
src/lib/Client/DaprHttpClient.php 83.33% <100.00%> (+83.33%) ⬆️
src/lib/Client/HttpPubSubTrait.php 100.00% <100.00%> (+100.00%) ⬆️
src/lib/Client/HttpStateTrait.php 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57efb04...ab96eb6. Read the comment docs.

@withinboredom withinboredom changed the title Update pubsub to use new topic Update pubsub to use new client Jul 16, 2021
@withinboredom withinboredom merged commit 6fb3015 into main Jul 16, 2021
@withinboredom withinboredom deleted the refactor/pubsub branch July 16, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants