Skip to content

Commit

Permalink
Improved MM test fix for quickstarts (#548)
Browse files Browse the repository at this point in the history
* Fixing error caused by route to * conflicing with /dapr/subscribe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrating from `requests` to `axios` to improve supportability

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changed from " to ' matching existing styles for Javascript

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changing `axios` from import to require('axios'), matching require('express')

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Consistent use of Async enabled http code

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrated distributed calculator from `request` with pipe to `axios` with service invoke.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixed react * route bug that conflicts with /dapr/subscribe route

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Reducing log levels introduced by migration.  added debug flag.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating MM test to match improved precision of Express server.js with Axios.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* updating console.log from console.debug (minor) for consistency.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated vars to const, and then updated README to match.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Async posts needed await.  Readme's tweaked to match updates.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Async should pair with await

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing comment

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Removing commented out pipe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in.  Updated dependencies

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Hotfix to test, given precision sensitivity on test output number

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing all remaining decimal precision issues with MM tests in readmes, including observability which now fails

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
  • Loading branch information
paulyuk and shubham1172 authored Feb 24, 2022
1 parent f80fe76 commit 7fc6dc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions distributed-calculator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ name: "Curl test"
86
18
1.5294117647058822
1768.0
1768
{"operation":null,"total":"54","next":null}
```
Expand Down Expand Up @@ -567,7 +567,7 @@ You should get the following output:
86
18
1.5294117647058822
1768.0
1768
{"operation":null,"total":"54","next":null}
```
Expand Down
2 changes: 1 addition & 1 deletion observability/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ expected_stdout_lines:
- "86"
- "18"
- "1.5294"
- "1768.0"
- "1768"
- '"total":"54"'
output_match_mode: substring
name: "Curl test"
Expand Down

0 comments on commit 7fc6dc9

Please sign in to comment.