-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 #1001
Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 #1001
Conversation
Signed-off-by: Anton Troshin <anton@diagrid.io>
73128ec
to
c5caa46
Compare
Hi that's really cool, @antontroshin thank you for the contribution. Does it work well with this change from what you can tell? ready to go? I'm running tests now. |
I did test this locally, but had to do a few manual changes, due to the image location. cd tutorials/pub-sub/csharp-subscriber
dotnet restore
dotnet build -o out
docker buildx build -t csharp-subscriber:test .
kind load docker-image csharp-subscriber:test
cd .. Manually update ...
containers:
- name: csharp-subscriber
image: csharp-subscriber:test
imagePullPolicy: IfNotPresent
... Then apply the updated manifest
|
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
…-csharp-subscriber-docker-base-image
* Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 Signed-off-by: Anton Troshin <anton@diagrid.io> * Update Dockerfile Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Anton Troshin <anton@diagrid.io> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
@holopin-bot @antontroshin Thanks! |
Congratulations @antontroshin, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbi07105450cl4ketlwwjv This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Update tutorials pub-sub csharp-subscriber image to dotnet 8.0
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1000
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: