Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 #1001

Merged

Conversation

antontroshin
Copy link
Contributor

Description

Update tutorials pub-sub csharp-subscriber image to dotnet 8.0

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1000

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Anton Troshin <anton@diagrid.io>
@antontroshin antontroshin force-pushed the fix-csharp-subscriber-docker-base-image branch from 73128ec to c5caa46 Compare March 14, 2024 06:13
@paulyuk
Copy link
Contributor

paulyuk commented Mar 27, 2024

Hi that's really cool, @antontroshin thank you for the contribution. Does it work well with this change from what you can tell? ready to go? I'm running tests now.

@antontroshin
Copy link
Contributor Author

I did test this locally, but had to do a few manual changes, due to the image location.
Using kind local cluster.

cd tutorials/pub-sub/csharp-subscriber
dotnet restore
dotnet build -o out
docker buildx build -t csharp-subscriber:test .
kind load docker-image csharp-subscriber:test
cd ..

Manually update tutorials/pub-sub/deploy/csharp-subscriber.yaml container image location and imagePullPolicy

...
      containers:
      - name: csharp-subscriber
        image: csharp-subscriber:test
        imagePullPolicy: IfNotPresent
...

Then apply the updated manifest
kubectl apply -f deploy/csharp-subscriber.yaml
Observe logs

➜  kubectl logs deployments/csharp-subscriber
Defaulted container "csharp-subscriber" out of: csharp-subscriber, daprd
warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Overriding address(es) 'http://*:8080'. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5009
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /app

artursouza and others added 2 commits July 3, 2024 12:26
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@yaron2 yaron2 merged commit e8d195a into dapr:master Jul 22, 2024
5 of 7 checks passed
@antontroshin antontroshin deleted the fix-csharp-subscriber-docker-base-image branch July 22, 2024 21:28
paulyuk pushed a commit that referenced this pull request Jul 29, 2024
* Update tutorials pub-sub csharp-subscriber image to dotnet 8.0

Signed-off-by: Anton Troshin <anton@diagrid.io>

* Update Dockerfile

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

---------

Signed-off-by: Anton Troshin <anton@diagrid.io>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
@marcduiker
Copy link
Contributor

@holopin-bot @antontroshin Thanks!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @antontroshin, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbi07105450cl4ketlwwjv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pub-sub tutorial csharp-subscriber pod crash, running .NET8 in .NET7 container
5 participants