-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded springboot to 3.3.1 and bumped up other dependencies #1044
feat: upgraded springboot to 3.3.1 and bumped up other dependencies #1044
Conversation
…o latest. docs: Updated read me files to use Java 17 as baseline Signed-off-by: amardeep2006 <amardeep2006@gmail.com>
@paulyuk @msfussell Please have a look at the PR once you get chance. I have tested the build via github action in my repo fork as well. |
@amardeep2006 - Thanks for this PR. Will take a look. @salaboy - Please also review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks a lot @amardeep2006 for these changes.
@msfussell looks good to me, I've approved this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an generous contribution, thank you for this.
- [Oracle JDK 11](https://www.oracle.com/technetwork/java/javase/downloads/index.html#JDK11) | ||
- [OpenJDK 11](https://jdk.java.net/11/) | ||
- Java JDK 17 (or greater): | ||
- [Microsoft JDK 17](https://learn.microsoft.com/en-us/java/openjdk/download#openjdk-17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised Java 21 LTS is not the most used, but looking at State of java reports, those agree Java 17 is correct for right now.
feat: bumped up dependencies for Java Quickstarts , Springboot 2 is out of support so i have changes all the projects to use latest springboot 3 version available on the day of raising PR. I have tested all projects locally and github actions as well.
docs: Updated read me files to use Java 17 as baseline
Signed-off-by: amardeep2006 amardeep2006@gmail.com
Description
Please explain the changes you've made
Upgraded Java Quickstarts to latest versions of dependencies.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
#1042
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: