Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows to use docker compose instead of docker-compose #1089

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

artursouza
Copy link
Member

Description

Fix workflows to use docker compose instead of docker-compose

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: n/a

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza requested review from a team as code owners August 8, 2024 20:20
@paulyuk
Copy link
Contributor

paulyuk commented Aug 8, 2024

@artursouza why is this needed, what changed? I see docker-compose up is failing and podman steps are skipped.

https://github.com/dapr/quickstarts/actions/runs/10308451803/job/28535885852?pr=1088#step:14:2397

@artursouza
Copy link
Member Author

@artursouza why is this needed, what changed? I see docker-compose up is failing and podman steps are skipped.

https://github.com/dapr/quickstarts/actions/runs/10308451803/job/28535885852?pr=1088#step:14:2397

docker-compose is not supported anymore in GH runners. Everyone is moving to docker compose now.

@paulyuk paulyuk merged commit b16853b into dapr:release-1.14 Aug 8, 2024
7 checks passed
@paulyuk paulyuk mentioned this pull request Aug 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants