fix(go-http): http quickstart is broken #885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Go HTTP quickstart for pubsub is currently broken. It tries to unmarshal the data the publisher sends into a string. It is not a string, but rather a json string of a map[string]int. I checked with other languages such as python and it seems they also expect a map so went with that. Tested and fixed my issue.
FYI: fixed bug needed to set content-type to application/json. So kinda not a bug cause was originally a string because the http default in golang seems to be
text/plain
. Regardless, think this is a small improvement for consistency with the other languages (others send regular json payload) and too easy of a bug introduced if they take quickstart and adapt it to there own to send json and get confused like me lol.Before Bug Fix
After Bug Fix 🤌
Issue reference
Quick bug fix.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: