Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python pub_sub sdk example #889

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Update Python pub_sub sdk example #889

merged 1 commit into from
Sep 21, 2023

Conversation

zhangcheng
Copy link
Contributor

@zhangcheng zhangcheng commented Jul 25, 2023 •
edited
Loading

Description

  • Correct the app port in README to make it works again.
  • In particular, this fix makes the fastapi example works again.
  • The flask example previously still works, due to its code fetchs the app port via the env variable.

Issue reference

N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@zhangcheng
Update Python pub_sub sdk example
15fa8a2 
- Correct the app port in README to make it works again.
- In particular, this fix makes the fastapi example works again.
- The flask example previously still works, due to its code fetchs the app port via the env variable.

Signed-off-by: ZHANG Cheng <czhang.oss@gmail.com>
rabollin
rabollin reviewed Sep 6, 2023
View reviewed changes
pub_sub/python/sdk/README.md
-->

```bash
dapr run --app-id order-processor-sdk-fastapi --resources-path ../../../components/ --app-port 6003 -- uvicorn app:app --port 6003
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any app defined to run on port 6003; app.py in order-processor-fastapi should have app defined on port 6003.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any app defined to run on port 6003; app.py in order-processor-fastapi should have app defined on port 6003.

The port is defined by uvicorn app:app --port 6003 part.

msfussell
msfussell approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's watch out to see if the timeout is too long in the new STEP test

@msfussell msfussell merged commit 7b0b832 into dapr:master Sep 21, 2023
5 of 6 checks passed
@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabollin rabollin rabollin left review comments

@msfussell msfussell msfussell approved these changes

Assignees

@zhangcheng zhangcheng

Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangcheng @msfussell @rabollin @yaron2