Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes port 6003 conflict between Go Pub-sub and Go bindings. #942

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Oct 2, 2023

…issue

The timing of tests leads to conflict on port 6003

Please explain the changes you've made

Issue reference

Current failed tests for Go

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

…ssue

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk requested a review from msfussell October 2, 2023 15:18
@paulyuk paulyuk self-assigned this Oct 2, 2023
@paulyuk paulyuk added the P0 label Oct 2, 2023
@paulyuk paulyuk added this to the 1.12 milestone Oct 2, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@paulyuk paulyuk merged commit 8ecc595 into dapr:release-1.12 Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants