-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade axum to 0.7.4 #121
Conversation
f634339
to
e2eeb4d
Compare
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
42e185f
to
e0e2b81
Compare
9f2f5ec
to
17280bd
Compare
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
e4fc1b7
to
bb515e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First look
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
Signed-off-by: Cyril Scetbon <cscetbon@gmail.com>
@yaron2 Can you take a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The upgrade path makes sense, thanks for the clarifications.
@yaron2 Let's do it in another PR, but it would need a good description cause I've read that the dapr side car currently does not support invoking actors via grpc, and other SDKs use an env variable called That PR got a 👍 from both of you so it should be ready to merge 😉 |
Including in this PR: