Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDK resiliency #167

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Apr 18, 2024

Description

  • Remove any sleeps from the examples.
  • Implements client connection resiliency
    • On startup
    • Throughout the client lifecycle
  • Add support for two env vars:
    • DAPR_API_MAX_RETRIES
    • DAPR_API_TIMEOUT_MILLISECONDS
  • Add optional parameters when instantiating the client that will take priority over env vars
  • Compatibility tests
    • On startup
    • Throughout the client lifecycle
  • Documentation

Issue reference

This PR will close #14

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee added the P0 label Apr 18, 2024
@mikeee mikeee added the enhancement New feature or request label Apr 18, 2024
@mikeee mikeee added this to the 1.14 milestone Apr 18, 2024
@mikeee mikeee self-assigned this Apr 18, 2024
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee force-pushed the resiliency-implementation branch from d842272 to fd5f6fe Compare April 19, 2024 11:18
mikeee added 4 commits April 19, 2024 12:24
The client now has a configurable exponential backoff policy to
aid with resiliency. This can be configured by setting the
`DAPR_API_MAX_RETRIES` env var to a value greater than the 0
default.

Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee force-pushed the resiliency-implementation branch from d864d0b to 3a42fbc Compare April 21, 2024 21:16
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 20, 2024
@mikeee mikeee added pinned dapr-bot exemption and removed stale labels Jun 20, 2024
mikeee added 5 commits July 7, 2024 23:13
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee modified the milestones: 1.14, 1.15 Jul 23, 2024
@mikeee mikeee modified the milestones: 0.16.0, 0.17.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 pinned dapr-bot exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the logic to retry until grpc port is assigned to daprd
1 participant