Updates gRPC proto - dapr v1.10 release #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com>
yaron2
approved these changes
Feb 7, 2023
4 tasks
Comment on lines
+27
to
34
| Error::GrpcError(GrpcError { _status: error }) | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct GrpcError { | ||
| status: TonicStatus, | ||
| _status: TonicStatus, | ||
| } |
There was a problem hiding this comment.
I don't think we should use _ to prevent warnings for fields like this. If it is unused, but available for use (or intended for future use), it should either:
- show up as a clippy warning
- be ignored by clippy
cscetbon
pushed a commit
to cscetbon/rust-sdk
that referenced
this pull request
Jan 20, 2024
* updates grpc proto for dapr v1.10 release Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com> * updates dependencies to most recent Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com> --------- Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com>
zedgell
pushed a commit
to zedgell/rust-sdk
that referenced
this pull request
Mar 17, 2024
* updates grpc proto for dapr v1.10 release Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com> * updates dependencies to most recent Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com> --------- Signed-off-by: Roberto J Rojas <robertojrojas@gmail.com> Signed-off-by: Zachary Edgell <zacharyedgell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roberto J Rojas robertojrojas@gmail.com