Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeedGenerator and MessageAnalyzer apps #36

Merged
merged 4 commits into from
Mar 30, 2020
Merged

FeedGenerator and MessageAnalyzer apps #36

merged 4 commits into from
Mar 30, 2020

Conversation

LMWF
Copy link
Contributor

@LMWF LMWF commented Mar 27, 2020

This PR contains the feed generator and message analyzer apps - #12 and #13.

feed-generator/Program.cs Show resolved Hide resolved
feed-generator/Post.cs Outdated Show resolved Hide resolved
longhaul-test/binding.yaml Show resolved Hide resolved
message-analyzer/PostWithSentiment.cs Outdated Show resolved Hide resolved
message-analyzer/PostWithSentiment.cs Outdated Show resolved Hide resolved
message-analyzer/Startup.cs Show resolved Hide resolved
feed-generator/Program.cs Outdated Show resolved Hide resolved
feed-generator/Program.cs Show resolved Hide resolved
feed-generator/Startup.cs Outdated Show resolved Hide resolved
longhaul-test/message-analyzer-deploy.yml Outdated Show resolved Hide resolved
message-analyzer/PostWithSentiment.cs Outdated Show resolved Hide resolved
}
}

internal int GenerateRandomSentiment()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a different distribution for each sentiment?

Something like:
Positive: 70%
Neutral: 20%
Negative: 10%

If we have 5 starts, then I would say it would start more like a normal distribution, with peak at 3 or 4. This is just to make the output look legit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to do this later.

Copy link
Contributor

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to create the solution and put all app proj into single solution to maintain the apps.

@LMWF LMWF merged commit 9c38cf7 into master Mar 30, 2020
@LMWF LMWF deleted the feedandanalyzer branch March 30, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants