Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ: Add decoder for Fine Offset (FOSHK) weather station equipment #125

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amotl
Copy link
Member

@amotl amotl commented Mar 1, 2023

Dear all,

originally coming from GH-123, this patch brings in a more solid implementation for acquiring measurement data from weather stations manufactured by Fine Offset Electronics, based on the excellent ecowitt2mqtt program.

With kind regards,
Andreas.

Details

The hardware is produced by Shenzhen Fine Offset Electronics Co., Ltd. (FOSHK) aka. Fine Offset aka. OFFSET. This includes brands that white-label Fine Offset equipment, such as:

  • Ambient Weather (U.S.)
  • Ecowitt (China, Hong Kong)
  • Froggit (Germany)

References

Backlog

  • Add software tests
  • Add documentation

@amotl amotl force-pushed the daq-fineoffset branch 2 times, most recently from 14b023a to a80d36a Compare March 1, 2023 19:59
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.26 🎉

Comparison is base (fa580a6) 52.69% compared to head (1391232) 52.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   52.69%   52.96%   +0.26%     
==========================================
  Files          99      100       +1     
  Lines        5224     5251      +27     
==========================================
+ Hits         2753     2781      +28     
+ Misses       2471     2470       -1     
Flag Coverage Δ
unittests 52.96% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kotori/daq/decoder/fineoffset.py 100.00% <100.00%> (ø)
kotori/io/protocol/http.py 82.94% <100.00%> (+0.17%) ⬆️
kotori/daq/graphing/grafana/dashboard.py 90.03% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

amotl added 2 commits March 2, 2023 01:25
Through the excellent `ecowitt2mqtt` machinery [1], this supports any
weather station/gateway that is produced by Shenzhen Fine Offset
Electronics Co., Ltd. [2] aka. Fine Offset aka. OFFSET. This includes
brands that white-label Fine Offset equipment, such as:

- Ambient Weather (U.S.)
- Ecowitt (China, Hong Kong)
- Froggit (Germany)

By default, `ecowitt2mqtt` is configured to output data in the "metric"
unit system.

[1] https://github.com/bachya/ecowitt2mqtt
[2] https://www.foshk.com/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant