Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfluxDB] Improve export adapter interfaces, and naming things #151

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 18, 2023

Pulled out of GH-148, this patch sets the stage for more easily bringing in different database adapters when exporting data.

Other than this, there are also a few maintenance adjustments.

amotl added 2 commits June 18, 2023 17:54
This patch sets the stage for more easily bringing in different database
adapters when _exporting_ data.
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 77.06% and project coverage change: +10.83 🎉

Comparison is base (b2817b6) 67.43% compared to head (52e8d5e) 78.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #151       +/-   ##
===========================================
+ Coverage   67.43%   78.26%   +10.83%     
===========================================
  Files          65       55       -10     
  Lines        3565     3009      -556     
===========================================
- Hits         2404     2355       -49     
+ Misses       1161      654      -507     
Flag Coverage Δ
unittests 78.26% <77.06%> (+10.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kotori/io/protocol/util.py 62.11% <45.94%> (-4.83%) ⬇️
kotori/io/export/database.py 86.48% <86.48%> (ø)
kotori/daq/storage/influx.py 78.37% <100.00%> (+19.28%) ⬆️
kotori/io/protocol/forwarder.py 96.38% <100.00%> (ø)
kotori/io/protocol/http.py 83.45% <100.00%> (+0.69%) ⬆️
kotori/io/protocol/influx.py 93.75% <100.00%> (+32.63%) ⬆️
kotori/io/protocol/target.py 60.91% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl amotl force-pushed the amo/generalize-database-export branch from a22da7c to 52e8d5e Compare June 18, 2023 15:55
@amotl amotl marked this pull request as ready for review June 18, 2023 16:04
@amotl amotl merged commit 9f5ec6b into main Jun 18, 2023
@amotl amotl deleted the amo/generalize-database-export branch June 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant