Merge branch 'JFormDesigner:main' into classx

.github/workflows/ci.yml

@@ -40,7 +40,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: gradle/wrapper-validation-action@v1
+      - uses: gradle/wrapper-validation-action@v2
         if: matrix.java == '8'
 
       - name: Setup Java ${{ matrix.java }}

.github/workflows/natives.yml

@@ -30,7 +30,7 @@ jobs:
         steps:
             - uses: actions/checkout@v4
 
-            - uses: gradle/wrapper-validation-action@v1
+            - uses: gradle/wrapper-validation-action@v2
 
             - name: Setup Java 11
               uses: actions/setup-java@v4

flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatFileChooserUI.java

@@ -429,7 +429,7 @@ public FlatShortcutsPanel( JFileChooser fc ) {
 			iconFunction = (Function<File, Icon>) UIManager.get( "FileChooser.shortcuts.iconFunction" );
 
 			FileSystemView fsv = fc.getFileSystemView();
-			File[] files = getChooserShortcutPanelFiles( fsv );
+			File[] files = JavaCompatibility2.getChooserShortcutPanelFiles( fsv );
 			if( filesFunction != null )
 				files = filesFunction.apply( files );
 
@@ -498,32 +498,6 @@ protected JToggleButton createButton( String name, Icon icon ) {
 			return button;
 		}
 
-		protected File[] getChooserShortcutPanelFiles( FileSystemView fsv ) {
-			try {
-				if( SystemInfo.isJava_12_orLater ) {
-					Method m = fsv.getClass().getMethod( "getChooserShortcutPanelFiles" );
-					File[] files = (File[]) m.invoke( fsv );
-
-					// on macOS and Linux, files consists only of the user home directory
-					if( files.length == 1 && files[0].equals( new File( System.getProperty( "user.home" ) ) ) )
-						files = new File[0];
-
-					return files;
-				} else if( SystemInfo.isWindows ) {
-					Class<?> cls = Class.forName( "sun.awt.shell.ShellFolder" );
-					Method m = cls.getMethod( "get", String.class );
-					return (File[]) m.invoke( null, "fileChooserShortcutPanelFolders" );
-				}
-			} catch( IllegalAccessException ex ) {
-				// do not log because access may be denied via VM option '--illegal-access=deny'
-			} catch( Exception ex ) {
-				LoggingFacade.INSTANCE.logSevere( null, ex );
-			}
-
-			// fallback
-			return new File[0];
-		}
-
 		protected String getDisplayName( FileSystemView fsv, File file ) {
 			if( displayNameFunction != null ) {
 				String name = displayNameFunction.apply( file );

flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatMenuBarUI.java

@@ -27,7 +27,6 @@
 import java.beans.PropertyChangeListener;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicBoolean;
-import javax.swing.AbstractAction;
 import javax.swing.ActionMap;
 import javax.swing.BoxLayout;
 import javax.swing.JComponent;
@@ -39,7 +38,6 @@
 import javax.swing.MenuSelectionManager;
 import javax.swing.SwingUtilities;
 import javax.swing.UIManager;
-import javax.swing.plaf.ActionMapUIResource;
 import javax.swing.plaf.ComponentUI;
 import javax.swing.plaf.UIResource;
 import javax.swing.plaf.basic.BasicMenuBarUI;
@@ -144,12 +142,10 @@ protected void uninstallListeners() {
 	protected void installKeyboardActions() {
 		super.installKeyboardActions();
 
+		// get shared action map, used for all menu bars
 		ActionMap map = SwingUtilities.getUIActionMap( menuBar );
-		if( map == null ) {
-			map = new ActionMapUIResource();
-			SwingUtilities.replaceUIActionMap( menuBar, map );
-		}
-		map.put( "takeFocus", new TakeFocus() );
+		if( map != null && !(map.get( "takeFocus" ) instanceof TakeFocusAction) )
+			map.put( "takeFocus", new TakeFocusAction( "takeFocus" ) );
 	}
 
 	/** @since 2 */
@@ -365,16 +361,20 @@ public void layoutContainer( Container target ) {
 		}
 	}
 
-	//---- class TakeFocus ----------------------------------------------------
+	//---- class TakeFocusAction ----------------------------------------------
 
 	/**
 	 * Activates the menu bar and shows mnemonics.
 	 * On Windows, the popup of the first menu is not shown.
 	 * On other platforms, the popup of the first menu is shown.
 	 */
-	private static class TakeFocus
-		extends AbstractAction
+	private static class TakeFocusAction
+		extends FlatUIAction
 	{
+		TakeFocusAction( String name ) {
+			super( name );
+		}
+
 		@Override
 		public void actionPerformed( ActionEvent e ) {
 			JMenuBar menuBar = (JMenuBar) e.getSource();

flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatTabbedPaneUI.java

@@ -3985,10 +3985,8 @@ protected void layoutChildComponent( Component c, Rectangle contentAreaBounds )
 	//---- class RunWithOriginalLayoutManagerDelegateAction -------------------
 
 	private static class RunWithOriginalLayoutManagerDelegateAction
-		implements Action
+		extends FlatUIAction
 	{
-		private final Action delegate;
-
 		static void install( ActionMap map, String key ) {
 			Action oldAction = map.get( key );
 			if( oldAction == null || oldAction instanceof RunWithOriginalLayoutManagerDelegateAction )
@@ -3998,24 +3996,9 @@ static void install( ActionMap map, String key ) {
 		}
 
 		private RunWithOriginalLayoutManagerDelegateAction( Action delegate ) {
-			this.delegate = delegate;
-		}
-
-		@Override
-		public Object getValue( String key ) {
-			return delegate.getValue( key );
+			super( delegate );
 		}
 
-		@Override
-		public boolean isEnabled() {
-			return delegate.isEnabled();
-		}
-
-		@Override public void putValue( String key, Object value ) {}
-		@Override public void setEnabled( boolean b ) {}
-		@Override public void addPropertyChangeListener( PropertyChangeListener listener ) {}
-		@Override public void removePropertyChangeListener( PropertyChangeListener listener ) {}
-
 		@Override
 		public void actionPerformed( ActionEvent e ) {
 			JTabbedPane tabbedPane = (JTabbedPane) e.getSource();

flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatUIAction.java

@@ -0,0 +1,62 @@
+/*
+ * Copyright 2024 FormDev Software GmbH
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.formdev.flatlaf.ui;
+
+import java.beans.PropertyChangeListener;
+import javax.swing.Action;
+
+/**
+ * Base class for UI actions used in ActionMap.
+ * (similar to class sun.swing.UIAction)
+ *
+ * @author Karl Tauber
+ * @since 3.4
+ */
+public abstract class FlatUIAction
+	implements Action
+{
+	protected final String name;
+	protected final Action delegate;
+
+	protected FlatUIAction( String name ) {
+		this.name = name;
+		this.delegate = null;
+	}
+
+	protected FlatUIAction( Action delegate ) {
+		this.name = null;
+		this.delegate = delegate;
+	}
+
+	@Override
+	public Object getValue( String key ) {
+		if( key == NAME && delegate == null )
+			return name;
+		return (delegate != null) ? delegate.getValue( key ) : null;
+	}
+
+	@Override
+	public boolean isEnabled() {
+		return (delegate != null) ? delegate.isEnabled() : true;
+	}
+
+	// do nothing in following methods because this class is immutable
+	@Override public void putValue( String key, Object value ) {}
+	@Override public void setEnabled( boolean b ) {}
+	@Override public void addPropertyChangeListener( PropertyChangeListener listener ) {}
+	@Override public void removePropertyChangeListener( PropertyChangeListener listener ) {}
+}

flatlaf-core/src/main/java/com/formdev/flatlaf/ui/JavaCompatibility2.java

@@ -16,6 +16,7 @@
 
 package com.formdev.flatlaf.ui;
 
+import java.io.File;
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
@@ -25,6 +26,7 @@
 import javax.swing.JPanel;
 import javax.swing.JTable;
 import javax.swing.JTree;
+import javax.swing.filechooser.FileSystemView;
 import javax.swing.plaf.ComponentUI;
 import javax.swing.text.JTextComponent;
 import com.formdev.flatlaf.util.LoggingFacade;
@@ -88,4 +90,64 @@ public static ComponentUI getUI( JComponent c ) {
 			return null;
 		}
 	}
+
+	/**
+	 * Java 8 - 11 on Windows: sun.awt.shell.ShellFolder.get( "fileChooserShortcutPanelFolders" )
+	 * <br>
+	 * Java 12: javax.swing.filechooser.FileSystemView.getChooserShortcutPanelFiles()
+	 *
+	 * @since 3.4
+	 */
+	public static File[] getChooserShortcutPanelFiles( FileSystemView fsv ) {
+		try {
+			if( SystemInfo.isJava_12_orLater ) {
+				Method m = fsv.getClass().getMethod( "getChooserShortcutPanelFiles" );
+				File[] files = (File[]) m.invoke( fsv );
+
+				// on macOS and Linux, files consists only of the user home directory
+				if( files.length == 1 && files[0].equals( new File( System.getProperty( "user.home" ) ) ) )
+					files = new File[0];
+
+				return files;
+			} else if( SystemInfo.isWindows ) {
+				Class<?> cls = Class.forName( "sun.awt.shell.ShellFolder" );
+				Method m = cls.getMethod( "get", String.class );
+				return (File[]) m.invoke( null, "fileChooserShortcutPanelFolders" );
+			}
+		} catch( IllegalAccessException ex ) {
+			// do not log because access may be denied via VM option '--illegal-access=deny'
+		} catch( Exception ex ) {
+			LoggingFacade.INSTANCE.logSevere( null, ex );
+		}
+
+		// fallback
+		return new File[0];
+	}
+
+	/**
+	 * Java 8: sun.awt.shell.ShellFolder.get( "fileChooserComboBoxFolders" )
+	 * <br>
+	 * Java 9: javax.swing.filechooser.FileSystemView.getChooserComboBoxFiles()
+	 *
+	 * @since 3.4
+	 */
+	public static File[] getChooserComboBoxFiles( FileSystemView fsv ) {
+		try {
+			if( SystemInfo.isJava_9_orLater ) {
+				Method m = fsv.getClass().getMethod( "getChooserComboBoxFiles" );
+				return (File[]) m.invoke( fsv );
+			} else {
+				Class<?> cls = Class.forName( "sun.awt.shell.ShellFolder" );
+				Method m = cls.getMethod( "get", String.class );
+				return (File[]) m.invoke( null, "fileChooserComboBoxFolders" );
+			}
+		} catch( IllegalAccessException ex ) {
+			// do not log because access may be denied via VM option '--illegal-access=deny'
+		} catch( Exception ex ) {
+			LoggingFacade.INSTANCE.logSevere( null, ex );
+		}
+
+		// fallback
+		return new File[0];
+	}
 }

flatlaf-testing/build.gradle.kts

@@ -41,6 +41,8 @@ dependencies {
 	implementation( libs.jide.oss )
 	implementation( libs.glazedlists )
 	implementation( libs.netbeans.api.awt )
+
+	components.all<TargetJvmVersion8Rule>()
 }
 
 applyLafs()
@@ -58,3 +60,13 @@ fun applyLafs() {
 			dependencies.implementation( parts[2] )
 	}
 }
+
+// rule that overrides 'org.gradle.jvm.version' with '8'
+// (required for Radiance, which requires Java 9, but FlatLaf build uses Java 8)
+abstract class TargetJvmVersion8Rule : ComponentMetadataRule {
+	override fun execute( context: ComponentMetadataContext ) {
+		context.details.allVariants {
+			attributes.attribute( TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE, 8 )
+		}
+	}
+}

flatlaf-testing/lafs.properties

@@ -1,5 +1,9 @@
-org.pushingpixels.substance.api.skin.SubstanceBusinessLookAndFeel = Substance Business;ctrl F5;org.pushing-pixels:radiance-substance:3.5.1
-org.pushingpixels.substance.api.skin.SubstanceGraphiteAquaLookAndFeel = Substance Graphite Aqua;ctrl F6
-com.alee.laf.WebLookAndFeel = WebLaf;ctrl F11;com.weblookandfeel:weblaf-ui:1.2.13
+org.pushingpixels.radiance.theming.api.skin.RadianceBusinessLookAndFeel = Radiance Business;ctrl F5;org.pushing-pixels:radiance-theming:7.0.1
+org.pushingpixels.radiance.theming.api.skin.RadianceGraphiteAquaLookAndFeel = Radiance Graphite Aqua;ctrl F6
+com.alee.laf.WebLookAndFeel = WebLaf;ctrl F11;com.weblookandfeel:weblaf-ui:1.2.14
 com.jgoodies.looks.plastic.PlasticLookAndFeel = JGoodies Looks Plastic;ctrl F12;com.jgoodies:jgoodies-looks:2.7.0
 com.jgoodies.looks.windows.WindowsLookAndFeel = JGoodies Looks Windows;ctrl F9
+mdlaf.MaterialLookAndFeel = Material-UI-Swing;shift F11;io.github.vincenzopalazzo:material-ui-swing:1.1.4
+com.github.weisj.darklaf.DarkLaf = DarkLaf;shift F12;com.github.weisj:darklaf-core:3.0.2
+com.github.weisj.darklaf.theme.laf.DarculaThemeDarklafLookAndFeel = DarkLaf Darcula;ctrl shift F12
+com.jtattoo.plaf.smart.SmartLookAndFeel = JTattoo;ctrl shift F11;com.jtattoo:JTattoo:1.6.13