Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to control the use of PV put completion #3

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

hinxx
Copy link
Contributor

@hinxx hinxx commented Apr 18, 2024

Possible solution for #2.

@darcato
Copy link
Owner

darcato commented Apr 18, 2024

Why not having an optional argument on the put method, for example wait_complete=True?

@hinxx
Copy link
Contributor Author

hinxx commented Apr 18, 2024

You're right, having an optional argument on the put itself seems more straightforward. I'll rework the PR and try to add doc change, too.

I was also thinking about the putComplete() matter. If the interpretation of it is strictly meant as an indication of async completion, then it would make sense that fsmIO._putComplete remains False in cases when wait_complete=False is used and the trigger with 'putcomp' is never issued in such case. If the PV put would fail the epicsIO.put() reports an error already.

What do you think?

@hinxx hinxx marked this pull request as draft April 18, 2024 17:37
hinxx and others added 2 commits April 18, 2024 21:42
…ructor

This way we can decide on async or regular PV puts at the time of put() call.
Bye default wait_complete=True to keep existing code working.
Docs were updated to note the change.
@darcato
Copy link
Owner

darcato commented Apr 19, 2024

I know that I proposed the name wait_complete but given the additional context probably it's better to stick with use_complete (the same as the underlying code) or use_callbacks, since this flag only enables/disables the put callbacks but it never waits for something.

@hinxx
Copy link
Contributor Author

hinxx commented Apr 19, 2024

Re-based to current master code, too.

@hinxx hinxx marked this pull request as ready for review April 19, 2024 12:10
@darcato darcato merged commit 96ddde2 into darcato:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants