-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inefficient and unused default merge conditional #160
Comments
Thanks for opening a new issue. The team has been notified and will review it as soon as possible. |
bionoren
added a commit
to modopayments/mergo
that referenced
this issue
Aug 11, 2020
darccio
added a commit
that referenced
this issue
Aug 11, 2020
fixed issue #160 by removing unused old test code
New version released: https://github.com/imdario/mergo/releases/tag/v0.3.11 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of this writing, merge.go:274-278 read thus:
This is the only place the text "TestIssue106" occurs in this codebase (confirmed via
find . -type f | xargs grep "TestIssue106"
). I suspect this is leftover from a recent testing refactor. The conditional isn't so bad, but the Sprintf overhead adds up for large structs. In addition to the possibility for unexpected prints if someone's struct happens to contain that string...This code is unused and should be removed.
The text was updated successfully, but these errors were encountered: