Skip to content

Commit

Permalink
Fix WCAG issues on the output page
Browse files Browse the repository at this point in the history
  • Loading branch information
darekkay committed May 30, 2023
1 parent 9eb3505 commit 4ccaa08
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- :boom: Drop Node 14 support.
- :rocket: Disable `axe-core` "landmark-complementary-is-top-level" rule by default as it's [buggy](https://github.com/dequelabs/axe-core/issues/3586).
- :bug: Fix WCAG issues on the output page.
- :hammer: Update dependencies.
- :hammer: Simplify GitHub CI.

Expand Down
2 changes: 2 additions & 0 deletions config.demo.json5
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"https://webaim.org/",
"https://www.a11yproject.com/",
"https://darekkay.com",
"https://darekkay.com/evaluatory/demo/",
"https://darekkay.com/evaluatory/demo/4.html",
"https://www.11ty.dev/docs/",
],
}
4 changes: 2 additions & 2 deletions src/modules/axe-core/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<li>
<strong class="{{ 'text-danger' if issueCount > 0 }}">{{ issueCount }} violation(s)</strong>
</li>
<li>View <a href="{{ jsonFileName }}">JSON results</a></li>
<li class="prose">View <a href="{{ jsonFileName }}">JSON results</a></li>
</ul>

{% for violation in violations %}
Expand All @@ -16,7 +16,7 @@
<use xlink:href="#icon-severity-{{ violation.severity }}"></use>
</svg> {{ violation.description }}
</h3>
<p>Violated
<p class="prose">Violated
<a href="{{ violation.helpUrl }}" target="_blank" rel="noopener">{{ violation.id }}</a> on:
<em>{{ violation.breakpoints.join(", ") }}</em></p>

Expand Down
4 changes: 2 additions & 2 deletions src/modules/html-validate/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<li>
<strong class="{{ 'text-danger' if issueCount > 0 }}">{{ issueCount }} violation(s)</strong>
</li>
<li>View <a href="{{ jsonFileName }}">JSON results</a></li>
<li class="prose">View <a href="{{ jsonFileName }}">JSON results</a></li>
</ul>

{% for violation in violations %}
Expand All @@ -16,7 +16,7 @@
<use xlink:href="#icon-severity-serious"></use>
</svg> {{ violation.message }}
</h3>
<p>Violated
<p class="prose">Violated
<a href="https://html-validate.org/rules/{{ violation.ruleId }}.html" target="_blank" rel="noopener">{{ violation.ruleId }}</a>
</p>
{% if violation.selector %}
Expand Down
2 changes: 1 addition & 1 deletion src/templates/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
<small>Last generated: {{ lastGenerated }}</small>
</p>
</main>
<footer class="inverted">
<footer class="inverted prose">
<span>Handmade with ♥ by <a href="https://darekkay.com" target="_blank" rel="noopener">Darek Kay</a></span>

<div class="flex items-center">
Expand Down
4 changes: 2 additions & 2 deletions src/templates/module.njk
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

<main>
<p><a href="index.html">← Back</a></p>
<p>Results for:
<p class="prose">Results for:
<a href="{{ url }}" target="_blank" rel="noopener">{{ url }}</a></p>

<ul>
Expand All @@ -39,7 +39,7 @@
{% endfor %}

</main>
<footer class="inverted">
<footer class="inverted prose">
<span>Handmade with ♥ by <a href="https://darekkay.com" target="_blank" rel="noopener">Darek Kay</a></span>

<div class="flex items-center">
Expand Down

0 comments on commit 4ccaa08

Please sign in to comment.