Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish #198

Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore(release): publish #198

merged 1 commit into from
Aug 30, 2024

Conversation

darenmalfait
Copy link
Owner

@darenmalfait darenmalfait commented Aug 29, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@nerdfish/ui@6.0.0

Major Changes

  • Namespacing components with dot notation (#199)

    Using the current way of using Object.assign to namespace components breaks
    consuming React Server Components. It also has limitations to tree-shaking
    capabilities.

    [https://github.com/Dot notation client component breaks consuming RSC. vercel/next.js#51593](See github issue)

    We need to change the way we namespace components to be compatible with React
    Server Components.

    Now, all components are being exported directly from the package, but also as
    a namespaced component in another way. The limitations is that namespaced
    component now always have a .Root element.

    for example, a Dialog would now be available as Dialog.Root, which to why
    these are breaking changes.

  • removed DoubleLabelLink
    (#199)

Patch Changes

  • fix the padding in Alert when there is an icon
    (#199)

  • add focus outline to Timepicker elements

Summary by CodeRabbit

  • New Features

    • Updated the @nerdfish/ui package to version 6.0.0, introducing new features and enhancements.
    • Components now require a .Root suffix for access, improving compatibility with React Server Components.
  • Breaking Changes

    • The DoubleLabelLink component has been removed.
    • Component access method has changed, requiring updates in how components are referenced.
  • Bug Fixes

    • Improved usability with padding adjustments in the Alert component and focus outlines in Timepicker elements.

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nerdfishui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 8:37am

@github-actions github-actions bot force-pushed the changeset-release/main branch from 459345a to 3e9aabc Compare August 30, 2024 08:36
Copy link

coderabbitai bot commented Aug 30, 2024

Walkthrough

The changes involve an update to the @nerdfish/ui package, incrementing its version from 5.0.2 to 6.0.0. This major version update introduces breaking changes, including a new namespacing method for components and the removal of the DoubleLabelLink component. Additionally, minor adjustments were made to improve usability in certain components.

Changes

Files Change Summary
apps/docs/package.json Updated @nerdfish/ui version from ^5.0.2 to ^6.0.0.
packages/ui/CHANGELOG.md Documented breaking changes in version 6.0.0, including new namespacing for components and removal of DoubleLabelLink. Minor fixes noted.
packages/ui/package.json Updated version from 5.0.2 to 6.0.0.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant UI as @nerdfish/ui

    App->>UI: Request Dialog component
    UI->>App: Return Dialog.Root component
    App->>UI: Request DoubleLabelLink component
    UI-->>App: Component not found (removed)
Loading

Poem

🐰 In the garden, changes bloom,
New names for components, making room.
The DoubleLabelLink has hopped away,
While Dialogs now dance and sway.
With every update, we leap with glee,
A brighter future, come hop with me! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 94d0299 and 3e9aabc.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (3)
  • apps/docs/package.json (1 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
Additional context used
LanguageTool
packages/ui/CHANGELOG.md

[grammar] ~15-~15: Check that the noun ‘namespace’ after the pronoun ‘we’ is correct. It’s possible that you may need to switch to a possessive pronoun, or use another part of speech.
Context: ...hub issue) We need to change the way we namespace components to be compatible with React ...

(PRP_VB)


[grammar] ~19-~19: You should probably use: “are”.
Context: ...mponent in another way. The limitations is that namespaced component now always ...

(AGREEMENT_SENT_START)

Additional comments not posted (2)
packages/ui/package.json (1)

3-3: Version Update Approved

The update of the version number from "5.0.2" to "6.0.0" is consistent with the major changes described in the PR. This change correctly signals a breaking change.

apps/docs/package.json (1)

26-26: Dependency Version Update Approved

The update of the @nerdfish/ui version from "^5.0.2" to "^6.0.0" in the dependencies is appropriate to align with the major changes in the @nerdfish/ui package.

packages/ui/CHANGELOG.md Show resolved Hide resolved
@darenmalfait darenmalfait merged commit 6af4ad5 into main Aug 30, 2024
4 checks passed
@darenmalfait darenmalfait deleted the changeset-release/main branch August 30, 2024 08:43
darenmalfait added a commit that referenced this pull request Dec 18, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant