-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): publish #198
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
459345a
to
3e9aabc
Compare
WalkthroughThe changes involve an update to the Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant UI as @nerdfish/ui
App->>UI: Request Dialog component
UI->>App: Return Dialog.Root component
App->>UI: Request DoubleLabelLink component
UI-->>App: Component not found (removed)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (3)
- apps/docs/package.json (1 hunks)
- packages/ui/CHANGELOG.md (1 hunks)
- packages/ui/package.json (1 hunks)
Additional context used
LanguageTool
packages/ui/CHANGELOG.md
[grammar] ~15-~15: Check that the noun ‘namespace’ after the pronoun ‘we’ is correct. It’s possible that you may need to switch to a possessive pronoun, or use another part of speech.
Context: ...hub issue) We need to change the way we namespace components to be compatible with React ...(PRP_VB)
[grammar] ~19-~19: You should probably use: “are”.
Context: ...mponent in another way. The limitations is that namespaced component now always ...(AGREEMENT_SENT_START)
Additional comments not posted (2)
packages/ui/package.json (1)
3-3
: Version Update ApprovedThe update of the version number from "5.0.2" to "6.0.0" is consistent with the major changes described in the PR. This change correctly signals a breaking change.
apps/docs/package.json (1)
26-26
: Dependency Version Update ApprovedThe update of the
@nerdfish/ui
version from "^5.0.2" to "^6.0.0" in the dependencies is appropriate to align with the major changes in the@nerdfish/ui
package.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@nerdfish/ui@6.0.0
Major Changes
Namespacing components with dot notation (#199)
Using the current way of using
Object.assign
to namespace components breaksconsuming React Server Components. It also has limitations to tree-shaking
capabilities.
[https://github.com/Dot notation client component breaks consuming RSC. vercel/next.js#51593](See github issue)
We need to change the way we namespace components to be compatible with React
Server Components.
Now, all components are being exported directly from the package, but also as
a namespaced component in another way. The limitations is that namespaced
component now always have a
.Root
element.for example, a
Dialog
would now be available asDialog.Root
, which to whythese are breaking changes.
removed
DoubleLabelLink
(#199)
Patch Changes
fix the padding in
Alert
when there is an icon(#199)
add focus outline to
Timepicker
elementsSummary by CodeRabbit
New Features
@nerdfish/ui
package to version 6.0.0, introducing new features and enhancements..Root
suffix for access, improving compatibility with React Server Components.Breaking Changes
DoubleLabelLink
component has been removed.Bug Fixes
Alert
component and focus outlines inTimepicker
elements.