Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore manual steps #105

Closed
aggarwalankush opened this issue Mar 8, 2018 · 4 comments · Fixed by #106
Closed

Ignore manual steps #105

aggarwalankush opened this issue Mar 8, 2018 · 4 comments · Fixed by #106

Comments

@aggarwalankush
Copy link

are we planning to resolve this issue? EddyVerbruggen#75

Maybe I can open a PR like last time but someone with objective c knowledge would be great.
@ghost
Copy link

ghost commented Mar 8, 2018

it would be great to get a PR, we could use the same flag in the query as used for Fit: filtered: true

@aggarwalankush
Copy link
Author

Replacing nil https://github.com/dariosalvi78/cordova-plugin-health/blob/master/src/ios/HealthKit.m#L1506 with
NSPredicate *predicate = [NSPredicate predicateWithFormat:@"metadata.%K != YES", HKMetadataKeyWasUserEntered];
works but I don't know how to pass it via filter.

aggarwalankush added a commit to aggarwalankush/cordova-plugin-health that referenced this issue Mar 13, 2018
@aggarwalankush
fix dariosalvi78#105
363a3bc 
optional filtered flag to ignore manual steps, fix dariosalvi78#105
@aggarwalankush aggarwalankush mentioned this issue Mar 13, 2018
Merged
@aggarwalankush
Copy link
Author

@dariosalvi78 opened the PR, would be great if mereged. Also, a release would be great else I'll just point to github. 👍

@ghost ghost closed this as completed in #106 Mar 13, 2018
ghost pushed a commit that referenced this issue Mar 13, 2018
Merge pull request #106 from aggarwalankush/patch-1
b5bb501 
fix #105
@ghost
Copy link

ghost commented Mar 13, 2018

thanks for this

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #105 aggarwalankush/cordova-plugin-health
1 participant
@aggarwalankush